<table><tr><td style="">ndavis added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16421">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D16421#348347" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D16421#348347</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Wow, these are truly excellent. I think you've done an amazing job!</p></div>
</blockquote>
<p>Thanks!</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>One thing I'd like to discuss is whether or not we want the <tt style="background: #ebebeb; font-size: 13px;">emblem-remove</tt> icon to be red. This color is typically reserved for destructive actions and error conditions, and the emblem as far as I can tell is only used in Dolphin--where its usage denotes something that is neither destructive nor an error. Users might be worried that clicking on it will actually remove the item! I wonder if a the Icon Orange color might be more suitable. What do you think?</p></blockquote>
<p>I agree with you, but I also don't like the look of orange. It's just not a color that I would expect. I would be OK with making <tt style="background: #ebebeb; font-size: 13px;">emblem-added</tt> and <tt style="background: #ebebeb; font-size: 13px;">emblem-remove</tt> grey like the reporter (Tyson Tan) from bug#399968 asked for, but I don't know if that would work well for programs besides Dolphin.<br />
Here's what orange would look like:<br />
<a href="https://phabricator.kde.org/F6349094" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6349094: Screenshot_20181024_215403.png</a></p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Another thing is the <tt style="background: #ebebeb; font-size: 13px;">emblem-symbolic-link</tt> icon. It's the only common-ish one that doesn't follow the pattern of having a colored background with a border, which might muddy the design language you've chosen (which I love).</p></blockquote>
<p>You're right, but I also like how the chain link looks. How is this? <a href="https://phabricator.kde.org/F6349126" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6349126: Screenshot_20181024_222138.png</a></p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Also, I don't think the filled-in background really works: <a href="https://phabricator.kde.org/F6349078" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6349078: link icon.png</a></p></blockquote>
<p>That's fair and after using it for a little while, it's actually pretty bad with the dark theme. I just saw <a href="https://phabricator.kde.org/D16307" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D16307</a>, so it seems to be unnecessary anyway.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Since this fixes all three bugs, you can replace</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">https://bugs.kde.org/show_bug.cgi?id=399356
https://bugs.kde.org/show_bug.cgi?id=399357
https://bugs.kde.org/show_bug.cgi?id=399968</pre></div>
<p>with</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">BUG: 399356
BUG: 399357
BUG: 399968
FIXED-IN: 5.52</pre></div></blockquote>
<p>You mean I should change the summary to say that?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R266 Breeze Icons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16421">https://phabricator.kde.org/D16421</a></div></div><br /><div><strong>To: </strong>ndavis, VDG<br /><strong>Cc: </strong>ngraham, bcooksley, kde-frameworks-devel, VDG, michaelh, bruns<br /></div>