<table><tr><td style="">elvisangelaccio added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16412">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16412#inline-89362">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knewfilemenu.cpp:755</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_firstFileEntry</span> <span style="color: #aa2211">==</span> <span style="color: #aa4000">nullptr</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                            <span class="n">m_firstFileEntry</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">&</span><span class="n">entry</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">!m_firstFileEntry</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16412#inline-89359">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knewfilemenu.cpp:1263-1299</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QString</span> <span class="n">text</span> <span style="color: #aa2211">=</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_firstFileEntry</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">text</span><span class="p">.</span><span class="n">remove</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"..."</span><span class="p">));</span> <span style="color: #74777d">// the ... is fine for the menu item but not for the default filename</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">text</span> <span style="color: #aa2211">=</span> <span class="n">text</span><span class="p">.</span><span class="n">trimmed</span><span class="p">();</span> <span style="color: #74777d">// In some languages, there is a space in front of "...", see bug 268895</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_copyData</span> <span style="color: #aa2211">=</span> <span class="n">KNewFileMenuCopyData</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_copyData</span><span class="p">.</span><span class="n">m_src</span> <span style="color: #aa2211">=</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_firstFileEntry</span><span style="color: #aa2211">-></span><span class="n">templatePath</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span class="n">defaultFile</span> <span style="color: #aa2211">=</span> <span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">fromLocalFile</span><span class="p">(</span><span class="n">directory</span><span class="p">.</span><span class="n">toLocalFile</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">'/'</span> <span style="color: #aa2211">+</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">encodeFileName</span><span class="p">(</span><span class="n">text</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can we try to not duplicate this code? We should create this new <tt style="background: #ebebeb; font-size: 13px;">createFile()</tt> function such that we can also call it from <tt style="background: #ebebeb; font-size: 13px;">executeRealFileOrDir()</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16412#inline-89361">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knewfilemenu.h:162</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">     */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">void</span> <span style="color: #004012">createFile</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing <span class="phabricator-remarkup-mention-unknown">@since</span></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16412">https://phabricator.kde.org/D16412</a></div></div><br /><div><strong>To: </strong>thsurrel, Frameworks<br /><strong>Cc: </strong>elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>