<table><tr><td style="">emateli updated this revision to Diff 44189.<br />emateli added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14631">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">use _p notation. Add BatchRenameDialog to installable headers</li>
</ul>

<hr class="remarkup-hr" />

<p>Besides any current review, the last step for this patch would be to actually use the BatchRenameJob already in KIO. Regarding that: Should I put it into a separate patch and make this depend on it or continue working here?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D14631?vs=42324&id=44189">https://phabricator.kde.org/D14631?vs=42324&id=44189</a></div></div><br /><div><strong>BRANCH</strong><div><div>batchrename2</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14631">https://phabricator.kde.org/D14631</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/CMakeLists.txt<br />
autotests/batchrenametypestest.cpp<br />
autotests/batchrenametypestest.h<br />
src/widgets/CMakeLists.txt<br />
src/widgets/rename/batchrenamedialog.cpp<br />
src/widgets/rename/batchrenamedialog.h<br />
src/widgets/rename/batchrenamedialogmodel_p.cpp<br />
src/widgets/rename/batchrenamedialogmodel_p.h<br />
src/widgets/rename/batchrenametypes_p.cpp<br />
src/widgets/rename/batchrenametypes_p.h<br />
src/widgets/rename/batchrenamevar_p.cpp<br />
src/widgets/rename/batchrenamevar_p.h<br />
src/widgets/rename/filenameutils_p.cpp<br />
src/widgets/rename/filenameutils_p.h<br />
tests/CMakeLists.txt<br />
tests/batchrenamedialogtest_gui.cpp</div></div></div><br /><div><strong>To: </strong>emateli, Frameworks, dfaure<br /><strong>Cc: </strong>asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns<br /></div>