<table><tr><td style="">safaalfulaij added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15829">View Revision</a></tr></table><br /><div><div><p>Since the joining between number and format is translatable, that's great. I meant that if it is kept untranslatable, problems regarding RTL will happen.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15829#inline-85667">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kformatprivate.cpp:115</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">const</span> <span class="n">PrefixMapEntry</span> <span class="n">map</span><span class="p">[]</span> <span style="color: #aa2211">=</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="p">{</span> <span class="n">KFormat</span><span style="color: #aa2211">::</span><span class="n">UnitPrefix</span><span style="color: #aa2211">::</span><span class="n">Yocto</span><span class="p">,</span> <span style="color: #601200">1e-24</span><span class="p">,</span> <span class="n">bpow</span><span class="p">(</span><span style="color: #aa2211">-</span><span style="color: #601200">80</span><span class="p">),</span> <span class="bright"></span><span class="n"><span class="bright">u</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">'y'</span></span> <span class="p">},</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="p">{</span> <span class="n">KFormat</span><span style="color: #aa2211">::</span><span class="n">UnitPrefix</span><span style="color: #aa2211">::</span><span class="n">Zepto</span><span class="p">,</span> <span style="color: #601200">1e-21</span><span class="p">,</span> <span class="n">bpow</span><span class="p">(</span><span style="color: #aa2211">-</span><span style="color: #601200">70</span><span class="p">),</span> <span class="bright"></span><span class="n"><span class="bright">u</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">'z'</span></span> <span class="p">},</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">{</span> <span class="n">KFormat</span><span style="color: #aa2211">::</span><span class="n">UnitPrefix</span><span style="color: #aa2211">::</span><span class="n">Yocto</span><span class="p">,</span> <span style="color: #601200">1e-24</span><span class="p">,</span> <span class="n">bpow</span><span class="p">(</span><span style="color: #aa2211">-</span><span style="color: #601200">80</span><span class="p">),</span> <span class="bright"></span><span class="n"><span class="bright">tr</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"y"</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Metric prefix for 10^⁻24"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span> <span class="p">},</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">{</span> <span class="n">KFormat</span><span style="color: #aa2211">::</span><span class="n">UnitPrefix</span><span style="color: #aa2211">::</span><span class="n">Zepto</span><span class="p">,</span> <span style="color: #601200">1e-21</span><span class="p">,</span> <span class="n">bpow</span><span class="p">(</span><span style="color: #aa2211">-</span><span style="color: #601200">70</span><span class="p">),</span> <span class="bright"></span><span class="n"><span class="bright">tr</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"z"</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Metric prefix for 10^⁻21"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span> <span class="p">},</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Line 160:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">} else {
    value /= entry->binaryFactor;
    prefixString = QString(entry->prefixChar).toUpper();</pre></div>

<p style="padding: 0; margin: 8px;">How this is “Metric”?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15829#inline-85666">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kformatprivate.cpp:168</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">dialect</span> <span style="color: #aa2211">==</span> <span class="n">KFormat</span><span style="color: #aa2211">::</span><span class="n">IECBinaryDialect</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">prefixString</span> <span style="color: #aa2211">+=</span> <span class="n">u</span><span style="color: #766510">'i'</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">And what about this? <em>It should never be a puzzle string by the way.</em></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15829">https://phabricator.kde.org/D15829</a></div></div><br /><div><strong>To: </strong>astippich, bruns, safaalfulaij<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>