<table><tr><td style="">emateli updated this revision to Diff 42324.<br />emateli marked 15 inline comments as done.<br />emateli added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14631">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">Code style fixes</li>
<li class="remarkup-list-item">use .insert instead of []</li>
<li class="remarkup-list-item">Indent Q_OBJECT</li>
<li class="remarkup-list-item">use isEmpty instead of len==0</li>
<li class="remarkup-list-item">use aggregate initialization</li>
<li class="remarkup-list-item">protected -> private</li>
<li class="remarkup-list-item">added parent check</li>
<li class="remarkup-list-item">use functions instead of QString fields</li>
<li class="remarkup-list-item">delete itemData</li>
<li class="remarkup-list-item">code format</li>
<li class="remarkup-list-item">FileNameUtils converted to namespace</li>
<li class="remarkup-list-item">remove unnecessary using</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D14631?vs=39137&id=42324">https://phabricator.kde.org/D14631?vs=39137&id=42324</a></div></div><br /><div><strong>BRANCH</strong><div><div>batchrename2</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14631">https://phabricator.kde.org/D14631</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/CMakeLists.txt<br />
autotests/batchrenametypestest.cpp<br />
autotests/batchrenametypestest.h<br />
src/widgets/CMakeLists.txt<br />
src/widgets/rename/batchrenamedialog.cpp<br />
src/widgets/rename/batchrenamedialog.h<br />
src/widgets/rename/batchrenamedialogmodel.cpp<br />
src/widgets/rename/batchrenamedialogmodel.h<br />
src/widgets/rename/batchrenametypes.cpp<br />
src/widgets/rename/batchrenametypes.h<br />
src/widgets/rename/batchrenamevar.cpp<br />
src/widgets/rename/batchrenamevar.h<br />
src/widgets/rename/filenameutils.cpp<br />
src/widgets/rename/filenameutils.h<br />
tests/CMakeLists.txt<br />
tests/batchrenamedialogtest_gui.cpp</div></div></div><br /><div><strong>To: </strong>emateli, Frameworks, dfaure<br /><strong>Cc: </strong>asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns<br /></div>