<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14757">View Revision</a></tr></table><br /><div><div><p>We don't actually need to create a messagebox because it's up to the caller to display the error in an appropriate manner. For example, Dolphin shows errors inline rather than with dialog boxes. So we shouldn't create a messagebox at all.</p>
<p>Let's see if we can figure out what to do:</p>
<p>Elsewhere in <tt style="background: #ebebeb; font-size: 13px;">src/core/copyjob.cpp</tt>, in <tt style="background: #ebebeb; font-size: 13px;">CopyJobPrivate::copyNextFile()</tt>, we already check for the size of each individual file:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (m_freeSpace < (*it).size) {
q->setError(ERR_DISK_FULL);
q->emitResult();
return;
}</pre></div>
<p>This works, but results in a half-finished copy, as it dies once it encounters the first file that doesn't fit. In <tt style="background: #ebebeb; font-size: 13px;">CopyJobPrivate::statCurrentSrc()</tt>, the comment <tt style="background: #ebebeb; font-size: 13px;">//TODO warn user beforehand if space is not enough</tt> gives us a clue for what to do: just add the same logic there, but check the total size of all copied files rather than the size of each individual file. So you would add the following:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (m_totalSize > m_freeSpace) {
q->setError(ERR_DISK_FULL);
q->emitResult();
return;
}</pre></div>
<p>For bonus points, set the error text to something appropriate for each error. For example, something like this would work for the "whole transfer is too big" case:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">q->setErrorText(
xi18n("There will not be enough free space available at <filename>%1</filename> to hold the file (%2 are required but only %3 are available",
m_globalDest.toLocalFile(),
KIO::convertSize(m_totalSize),
KIO::convertSize(m_freeSpace) ) );</pre></div></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14757#inline-83607">View Inline</a><span style="color: #4b4d51; font-weight: bold;">copyjob.cpp:887</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">qCDebug</span><span class="p">(</span><span class="n">KIO_COPYJOB_DEBUG</span><span class="p">)</span><span style="color: #aa2211"><<</span><span style="color: #766510">"Stating finished. To copy:"</span><span style="color: #aa2211"><<</span><span class="n">m_totalSize</span><span style="color: #aa2211"><<</span><span style="color: #766510">", available:"</span><span style="color: #aa2211"><<</span><span class="n">m_freeSpace</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">//TODO warn user beforehand if space is not enough</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_totalSize</span> <span style="color: #aa2211">></span> <span class="n">m_freeSpace</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can remove this comment now. :)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14757">https://phabricator.kde.org/D14757</a></div></div><br /><div><strong>To: </strong>shubham, pino, dfaure, broulik<br /><strong>Cc: </strong>ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns<br /></div>