<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15364">View Revision</a></tr></table><br /><div><div><p>You're absolutely right this is wrong.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p><span class="phabricator-remarkup-mention-unknown">@sune</span></p></blockquote>
<p>It is a crap default, but it shouldn't change per theme when a user is using Qqc2 directly. They might develop for this and then switch to desktop and then we have a big problem.</p>
<p>Fortunately few use this class yet.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Should Applications really be using Plasma style and components? I think they probably should be using desktop QQC2 style via Kirigami instead.</p></blockquote>
<p>Kirigami doesn't wrap qqc. One still uses qqc directly. On the phone that means this component.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15364">https://phabricator.kde.org/D15364</a></div></div><br /><div><strong>To: </strong>jbbgameich, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, svuorela, ngraham, kde-frameworks-devel, lnj, michaelh, bruns<br /></div>