<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13700">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81618">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:50</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromWCharArray</span><span class="p">((</span><span style="color: #aa4000">const</span> <span style="color: #aa4000">wchar_t</span><span style="color: #aa2211">*</span><span class="p">)</span><span class="n">t</span><span class="p">.</span><span class="n">toCWString</span><span class="p">(),</span> <span class="n">t</span><span class="p">.</span><span class="n">length</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is definitely broken:<br />
<a href="http://taglib.org/api/classTagLib_1_1String.html#a0ef8ad270d710863e0bb1c1b18cdb95d" class="remarkup-link" target="_blank" rel="noreferrer">http://taglib.org/api/classTagLib_1_1String.html#a0ef8ad270d710863e0bb1c1b18cdb95d</a></p>
<p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">const wchar_t* TagLib::String::toCWString () const</tt></p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">Returns a standard C-style (null-terminated) wide character version of this String. The returned string is encoded in UTF-16 (without BOM/CPU byte order), not UTF-32 even if wchar_t is 32-bit wide.</p></blockquote>
<p style="padding: 0; margin: 8px;"><a href="https://github.com/qt/qtbase/blob/c5307203f5c0b0e588cc93e70764c090dd4c2ce0/src/corelib/tools/qstring.h#L1027" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/qt/qtbase/blob/c5307203f5c0b0e588cc93e70764c090dd4c2ce0/src/corelib/tools/qstring.h#L1027</a></p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">inline QString QString::fromWCharArray(const wchar_t *string, int size)
{
return sizeof(wchar_t) == sizeof(QChar) ? fromUtf16(reinterpret_cast<const ushort *>(string), size)
: fromUcs4(reinterpret_cast<const uint *>(string), size);
}</pre></div>
<p style="padding: 0; margin: 8px;">Fortunately, platforms with wchar_t == wchar32_t are uncommon ...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81613">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:249</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// User Text Frame (TXXX) for ReplayGain</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">lstID3v2</span> <span style="color: #aa2211">=</span> <span class="n">mpegFile</span><span class="p">.</span><span class="n">ID3v2Tag</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">frameListMap</span><span class="p">()[</span><span style="color: #766510">"TXXX"</span><span class="p">];</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe better <tt style="background: #ebebeb; font-size: 13px;">// Check if there are any User Text Identification Frames (TXXX) at all</tt><br />
Technically, the <tt style="background: #ebebeb; font-size: 13px;">UserTextIdentificationFrame::find(...)</tt> below would be sufficient to lookup the tags.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81612">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:255</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">trackGainFrame</span> <span style="color: #aa2211">=</span> <span class="n">IdFrame</span><span style="color: #aa2211">::</span><span class="n">find</span><span class="p">(</span><span class="n">mpegFile</span><span class="p">.</span><span class="n">ID3v2Tag</span><span class="p">(),</span> <span style="color: #766510">"replaygain_track_gain"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">trackGainFrame</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">trackGainFrame</span><span style="color: #aa2211">-></span><span class="n">fieldList</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">()</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">data</span><span class="p">.</span><span class="n">replayGainTrackGain</span> <span style="color: #aa2211">=</span> <span class="n">convertWCharsToQString</span><span class="p">(</span><span class="n">trackGainFrame</span><span style="color: #aa2211">-></span><span class="n">fieldList</span><span class="p">().</span><span class="n">back</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Stray space in <tt style="background: #ebebeb; font-size: 13px;">if (...isEmpty() )</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13700">https://phabricator.kde.org/D13700</a></div></div><br /><div><strong>To: </strong>astippich, mgallien, bruns<br /><strong>Cc: </strong>kde-frameworks-devel, Baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>