<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13700">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81538">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:252</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">lstID3v2</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">TagLib</span><span style="color: #aa2211">::</span><span class="n">ID3v2</span><span style="color: #aa2211">::</span><span class="n">UserTextIdentificationFrame</span> <span style="color: #aa2211">*</span><span class="n">userTextFrame</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">userTextFrame</span> <span style="color: #aa2211">=</span> <span class="n">TagLib</span><span style="color: #aa2211">::</span><span class="n">ID3v2</span><span style="color: #aa2211">::</span><span class="n">UserTextIdentificationFrame</span><span style="color: #aa2211">::</span><span class="n">find</span><span class="p">(</span><span class="n">mpegFile</span><span class="p">.</span><span class="n">ID3v2Tag</span><span class="p">(),</span> <span style="color: #766510">"replaygain_track_gain"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can use a typedef in this scope, makes the long lines easier to read<br />
<a href="https://en.cppreference.com/w/cpp/language/namespace_alias" class="remarkup-link" target="_blank" rel="noreferrer">https://en.cppreference.com/w/cpp/language/namespace_alias</a></p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">typedef TagLib::ID3v2::UserTextIdentificationFrame IdFrame;
auto trackGainFrame = IdFrame::find(mpegFile.ID3v2Tag(), "replaygain_track_gain");
if (trackGainFrame) { ...</pre></div>

<p style="padding: 0; margin: 8px;">Using a distinct name for each instance makes it clearer these are independent frames.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81539">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:254</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">userTextFrame</span> <span style="color: #aa2211">=</span> <span class="n">TagLib</span><span style="color: #aa2211">::</span><span class="n">ID3v2</span><span style="color: #aa2211">::</span><span class="n">UserTextIdentificationFrame</span><span style="color: #aa2211">::</span><span class="n">find</span><span class="p">(</span><span class="n">mpegFile</span><span class="p">.</span><span class="n">ID3v2Tag</span><span class="p">(),</span> <span style="color: #766510">"replaygain_track_gain"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span> <span class="n">userTextFrame</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">data</span><span class="p">.</span><span class="n">replayGainTrackGain</span> <span style="color: #aa2211">=</span> <span class="n">convertWCharsToQString</span><span class="p">(</span><span class="n">userTextFrame</span><span style="color: #aa2211">-></span><span class="n">fieldList</span><span class="p">().</span><span class="n">back</span><span class="p">().</span><span class="n">toCString</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Remove the extra space inside the parentheses.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81542">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:255</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span> <span class="n">userTextFrame</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">data</span><span class="p">.</span><span class="n">replayGainTrackGain</span> <span style="color: #aa2211">=</span> <span class="n">convertWCharsToQString</span><span class="p">(</span><span class="n">userTextFrame</span><span style="color: #aa2211">-></span><span class="n">fieldList</span><span class="p">().</span><span class="n">back</span><span class="p">().</span><span class="n">toCString</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you can use TStringToQString<br />
<tt style="background: #ebebeb; font-size: 13px;">data.replayGainTrackGain = TStringToQString(userTextFrame->fieldList().back());</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81543">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:255</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span> <span class="n">userTextFrame</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">data</span><span class="p">.</span><span class="n">replayGainTrackGain</span> <span style="color: #aa2211">=</span> <span class="n">convertWCharsToQString</span><span class="p">(</span><span class="n">userTextFrame</span><span style="color: #aa2211">-></span><span class="n">fieldList</span><span class="p">().</span><span class="n">back</span><span class="p">().</span><span class="n">toCString</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">fieldList()</tt> may return an empty list, please add a check</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13700">https://phabricator.kde.org/D13700</a></div></div><br /><div><strong>To: </strong>astippich, mgallien, bruns<br /><strong>Cc: </strong>kde-frameworks-devel, Baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>