<table><tr><td style="">mgallien requested changes to this revision.<br />mgallien added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13700">View Revision</a></tr></table><br /><div><div><p>Some inline comments</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81100">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:254-263</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">strcmp</span><span class="p">(</span> <span class="n">userTextFrame</span><span style="color: #aa2211">-></span><span class="n">description</span><span class="p">().</span><span class="n">toCString</span><span class="p">(</span> <span style="color: #304a96">true</span> <span class="p">),</span> <span style="color: #766510">"replaygain_track_gain"</span> <span class="p">)</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">data</span><span class="p">.</span><span class="n">replayGainTrackGain</span> <span style="color: #aa2211">=</span> <span class="n">convertWCharsToQString</span><span class="p">(</span><span class="n">userTextFrame</span><span style="color: #aa2211">-></span><span class="n">fieldList</span><span class="p">().</span><span class="n">back</span><span class="p">().</span><span class="n">toCString</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">strcmp</span><span class="p">(</span> <span class="n">userTextFrame</span><span style="color: #aa2211">-></span><span class="n">description</span><span class="p">().</span><span class="n">toCString</span><span class="p">(</span> <span style="color: #304a96">true</span> <span class="p">),</span> <span style="color: #766510">"replaygain_track_peak"</span> <span class="p">)</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">data</span><span class="p">.</span><span class="n">replayGainTrackPeak</span> <span style="color: #aa2211">=</span> <span class="n">convertWCharsToQString</span><span class="p">(</span><span class="n">userTextFrame</span><span style="color: #aa2211">-></span><span class="n">fieldList</span><span class="p">().</span><span class="n">back</span><span class="p">().</span><span class="n">toCString</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">strcmp</span><span class="p">(</span> <span class="n">userTextFrame</span><span style="color: #aa2211">-></span><span class="n">description</span><span class="p">().</span><span class="n">toCString</span><span class="p">(</span> <span style="color: #304a96">true</span> <span class="p">),</span> <span style="color: #766510">"replaygain_album_gain"</span> <span class="p">)</span> <span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I am not a fan of the strcmp usage here. Is it not possible to do without them ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81095">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:468</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d">// Rating.</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">itMPC</span> <span style="color: #aa2211">=</span> <span class="n">lstMusepack</span><span class="p">.</span><span class="n">find</span><span class="p">(</span><span style="color: #766510">"RATING"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This change is unrelated to the patch. Please remove it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81096">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:662</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d">// Rating.</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">itOgg</span> <span style="color: #aa2211">=</span> <span class="n">lstOgg</span><span class="p">.</span><span class="n">find</span><span class="p">(</span><span style="color: #766510">"RATING"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same comment</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81097">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:934</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qDebug</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span class="n">data</span><span class="p">.</span><span class="n">replayGainAlbumGain</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">result</span><span style="color: #aa2211">-></span><span class="n">add</span><span class="p">(</span><span class="n">Property</span><span style="color: #aa2211">::</span><span class="n">ReplayGainAlbumGain</span><span class="p">,</span> <span class="n">data</span><span class="p">.</span><span class="n">replayGainAlbumGain</span><span class="p">.</span><span class="n">toDouble</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you remove it ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81098">View Inline</a><span style="color: #4b4d51; font-weight: bold;">taglibextractor.cpp:944</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">/* remove " dB" suffix */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">data</span><span class="p">.</span><span class="n">replayGainTrackGain</span><span class="p">.</span><span class="n">endsWith</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">" dB"</span><span class="p">),</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">CaseInsensitive</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Could you check if it is not faster to use QLatin1String here ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13700#inline-81099">View Inline</a><span style="color: #4b4d51; font-weight: bold;">properties.h:327-334</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">/**</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * Contains ReplayGain information for audio files</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * The album/track gain is given in "dB"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ReplayGainAlbumPeak</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ReplayGainAlbumGain</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ReplayGainTrackPeak</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please document each entry separately otherwise only the first one will have documentation (as seen on api.kde.org).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13700">https://phabricator.kde.org/D13700</a></div></div><br /><div><strong>To: </strong>astippich, mgallien, bruns<br /><strong>Cc: </strong>kde-frameworks-devel, Baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>