<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15000">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15000#inline-80136">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpropertiesdialog.cpp:1161</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">l</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QLabel</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"File system:"</span><span class="p">),</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_frame</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">grid</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span><span class="n">l</span><span class="p">,</span> <span class="n">curRow</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">AlignRight</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Captailize: File System</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15000#inline-80133">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpropertiesdialog.cpp:1164</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QStorageInfo</span> <span style="color: #aa2211">*</span><span class="n">fileSystem</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QStorageInfo</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"/"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This leaks, you can probably create it on the stack:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QStorageInfo storageInfo(...);</pre></div>

<p style="padding: 0; margin: 8px;">Also, shouldn't you pass <tt style="background: #ebebeb; font-size: 13px;">url.toLocalFile()</tt> instead of hardcoded <tt style="background: #ebebeb; font-size: 13px;">/</tt>?<br />
Also, move it in the <tt style="background: #ebebeb; font-size: 13px;">isLocal</tt> check as <tt style="background: #ebebeb; font-size: 13px;">QStorageInfo</tt> can only work on paths, not URLs.<br />
Also, what about <tt style="background: #ebebeb; font-size: 13px;">KMountPoint::mountType()</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15000#inline-80135">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpropertiesdialog.cpp:1169</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">l</span><span style="color: #aa2211">-></span><span class="n">setTextInteractionFlags</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">TextSelectableByMouse</span> <span style="color: #aa2211">|</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">TextSelectableByKeyboard</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">l</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">QString</span><span class="p">(</span><span class="n">fileSystem</span><span style="color: #aa2211">-></span><span class="n">fileSystemType</span><span class="p">()));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">QString::fromLatin1</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15000">https://phabricator.kde.org/D15000</a></div></div><br /><div><strong>To: </strong>shubham, dfaure<br /><strong>Cc: </strong>broulik, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>