<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14666">View Revision</a></tr></table><br /><div><div><p>Thanks ;)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14666#inline-77564">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kurlcombobox.cpp:358</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span class="bright"></span><span class="n"><span class="bright">d</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">default</span>List</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">removeAll</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">mit</span><span class="p">.</span><span class="n">value</span><span class="p">())<span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">d</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">item</span>List</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">at</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">i</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">get</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span class="n">mit</span><span class="p">.</span><span class="n">value</span><span class="p">())<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">itemList</span><span class="p">.</span><span class="n">erase</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">itemList</span><span class="p">.</span><span class="n">begin</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">i</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa4000">break</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">problem: <tt style="background: #ebebeb; font-size: 13px;">i</tt> shouldn't be in increased after this...</p>

<p style="padding: 0; margin: 8px;">Maybe this should use iterators instead?</p>

<p style="padding: 0; margin: 8px;">A unitttest is missing for this code path, in any case.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14666#inline-77565">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kurlcombobox.cpp:365</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">defaultList</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span class="n">i</span><span class="p">).</span><span class="n">get</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">mit</span><span class="p">.</span><span class="n">value</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">defaultList</span><span class="p">.</span><span class="n">erase</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">defaultList</span><span class="p">.</span><span class="n">begin</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">i</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                        <span style="color: #aa4000">break</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same here.</p>

<p style="padding: 0; margin: 8px;">Maybe erase(remove_if()) would be best.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14666">https://phabricator.kde.org/D14666</a></div></div><br /><div><strong>To: </strong>hallas, dfaure<br /><strong>Cc: </strong>dfaure, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>