<table><tr><td style="">rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14662">View Revision</a></tr></table><br /><div><div><p>Thanks for the help. Works great, just one inline question about an edge case (everything else LGTM).</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14662#inline-77598">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpropertiesdialog.cpp:853</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QGridLayout</span> <span style="color: #aa2211">*</span><span class="n">grid</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QGridLayout</span><span class="p">();</span> <span style="color: #74777d">// unknown rows</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_grid</span> <span style="color: #aa2211">=</span> <span class="n">grid</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">grid</span><span style="color: #aa2211">-></span><span class="n">setColumnStretch</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Just out of interest (don't change anything): I assume you don't fully transition everything to <tt style="background: #ebebeb; font-size: 13px;">d->m_grid</tt> to keep the diff small, or because <tt style="background: #ebebeb; font-size: 13px;">grid</tt> is more readable?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14662#inline-77597">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpropertiesdialog.cpp:1211-1214</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_fileNameLabel</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QLabel</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_frame</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_fileNameLabel</span><span style="color: #aa2211">-></span><span class="n">setTextInteractionFlags</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">TextSelectableByMouse</span> <span style="color: #aa2211">|</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">TextSelectableByKeyboard</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_fileNameLabel</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">oldName</span><span class="p">);</span> <span style="color: #74777d">// will get overwritten if d->bMultiple</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_grid</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_fileNameLabel</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">2</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Wouldn't this mean that calling <tt style="background: #ebebeb; font-size: 13px;">setFileNameReadOnly(true)</tt> multiple times will also create multiple labels on top of each other, breaking idempotence and resulting in some kind of bold font effect?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14662">https://phabricator.kde.org/D14662</a></div></div><br /><div><strong>To: </strong>dfaure, rkflx, shubham, ngraham<br /><strong>Cc: </strong>bruns, michaelh, kde-frameworks-devel, ngraham<br /></div>