<table><tr><td style="">bruns requested changes to this revision.<br />bruns added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13869">View Revision</a></tr></table><br /><div><div><p>The change needs a proper commit message. A reference to the bug tracker is not sufficient.</p>

<p>The commit message should (at least) include:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Description of the setup<ul class="remarkup-list">
<li class="remarkup-list-item">The UDI of the relevant Solid device</li>
<li class="remarkup-list-item">The UDIs of its parents</li>
<li class="remarkup-list-item">Relevant Solid attributes of the devices, e.g. from solid-hardware details</li>
</ul></li>
<li class="remarkup-list-item">Description of the actions done</li>
<li class="remarkup-list-item">Old and new behaviour</li>
</ul>

<p>Think of what happens if anyone changes the code later. The person must be able to replicate the setup, to check if any further changes break the code.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13869#inline-77248">View Inline</a><span style="color: #4b4d51; font-weight: bold;">udisksmanager.cpp:222</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">if</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">!</span></span><span class="bright"></span><span class="n"><span class="bright">udi</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">isEmpty</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">interfaces</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">isEmpty</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="n"><span class="bright">device</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">interfaces</span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span class="n"><span class="bright">isEmpty</span></span><span class="bright"></span><span class="p"><span class="bright">()))</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">interfaces</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">contains</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">UD2_DBUS_INTERFACE_FILESYSTEM</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa2211">||</span>  <span class="n">interfaces</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">UD2_DBUS_INTERFACE_LOOP</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">emit</span> <span class="n">deviceRemoved</span><span class="p">(</span><span class="n">udi</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">According to your description (which is hard to follow, because you refrain from writing complete sentences), what triggers here is the removal of the o.f.U2.FileSystem interface. There is no reasoning why the Loop interface matters here.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R245 Solid</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13869">https://phabricator.kde.org/D13869</a></div></div><br /><div><strong>To: </strong>anthonyfieroni, broulik, cfeck, dfaure, bruns<br /><strong>Cc: </strong>ngraham, bcooksley, bruns, kde-frameworks-devel, michaelh<br /></div>