<table><tr><td style="">rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14610">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14610#303537" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14610#303537</a>, <a href="https://phabricator.kde.org/p/rkflx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@rkflx</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p><tt style="background: #ebebeb; font-size: 13px;">KPropertiesDialog::setFileNameReadOnly</tt><br />
<tt style="background: #ebebeb; font-size: 13px;">m_bFromTemplate</tt></p></div>
</blockquote>
<p><a href="https://phabricator.kde.org/p/shubham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@shubham</a> Any comments on that (see my questions to <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> above)?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14610#inline-77233">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpropertiesdialog.cpp:988</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">d</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">bMultiple</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="n"><span class="bright">isTrash</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="n"><span class="bright">hasRoot</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">KFileItemListProperties</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">itemList</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">KFileItemList</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">item</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">bMultiple</span> <span style="color: #aa2211">||</span> <span class="n">isTrash</span> <span style="color: #aa2211">||</span> <span class="n">hasRoot</span> <span style="color: #aa2211">||</span> <span style="color: #aa2211">!</span><span class="n">itemList</span><span class="p">.</span><span class="n">supportsMoving</span><span class="p">()</span> <span style="color: #aa2211">||</span> <span class="p">(</span><span class="n">itemList</span><span class="p">.</span><span class="n">isDirectory</span><span class="p">()</span> <span style="color: #aa2211">&</span> <span style="color: #aa2211">!</span><span class="n">itemList</span><span class="p">.</span><span class="n">supportsWriting</span><span class="p">()))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QLabel</span> <span style="color: #aa2211">*</span><span class="n">lab</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QLabel</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_frame</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Without your patch, we only tested for <tt style="background: #ebebeb; font-size: 13px;">!itemList.supportsMoving()</tt>. Now you also test for <tt style="background: #ebebeb; font-size: 13px;">(itemList.isDirectory() & !itemList.supportsWriting()</tt>. Could you explain in what cases we need that new test? As far as I can see this blocks renaming the folder you removed the write permission from (while only its children should be prevented from being renamed).</p>
<p style="padding: 0; margin: 8px;">(<tt style="background: #ebebeb; font-size: 13px;">&</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">&&</tt> also caught my eye.)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14610#inline-77232">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpropertiesdialog.cpp:999-1019</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_lined</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KLineEdit</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_frame</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_lined</span><span style="color: #aa2211">-></span><span class="n">setObjectName</span><span class="p">(</span><span style="color: #766510">"KFilePropsPlugin::nameLineEdit"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_lined</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">filename</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">nameArea</span> <span style="color: #aa2211">=</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_lined</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_lined</span><span style="color: #aa2211">-></span><span class="n">setFocus</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #74777d"><span class="bright">//if we don't have permissions to rename, we need to make "m_lined" read only.</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_lined</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KLineEdit</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_frame</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_lined</span><span style="color: #aa2211">-></span><span class="n">setObjectName</span><span class="p">(</span><span style="color: #766510">"KFilePropsPlugin::nameLineEdit"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_lined</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">filename</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">nameArea</span> <span style="color: #aa2211">=</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_lined</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_lined</span><span style="color: #aa2211">-></span><span class="n">setFocus</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span class="n"><span class="bright">grid</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">addWidget</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">d</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">nameArea</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">curRow</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">++</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">2</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please don't add additional indentation here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14610#inline-77231">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpropertiesdialog.cpp:1021</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">grid</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">nameArea</span><span class="p">,</span> <span class="n">curRow</span><span style="color: #aa2211">++</span><span class="p">,</span> <span style="color: #601200">2</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You are moving that line to both the <tt style="background: #ebebeb; font-size: 13px;">if</tt> and the <tt style="background: #ebebeb; font-size: 13px;">else</tt> branch. Why not keep it here?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14610">https://phabricator.kde.org/D14610</a></div></div><br /><div><strong>To: </strong>shubham, rkflx, dfaure, ngraham<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>