<table><tr><td style="">leinir updated this revision to Diff 38506.<br />leinir marked an inline comment as done.<br />leinir added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6513">View Revision</a></tr></table><br /><div><div><p>Address mlaurent's comments</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D6513?vs=38489&id=38506">https://phabricator.kde.org/D6513?vs=38489&id=38506</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6513">https://phabricator.kde.org/D6513</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/knewstuffentrytest.cpp<br />
src/attica/atticaprovider.cpp<br />
src/core/CMakeLists.txt<br />
src/core/engine.cpp<br />
src/core/engine.h<br />
src/core/entryinternal.cpp<br />
src/core/entryinternal.h<br />
src/core/provider.h<br />
src/core/tagsfilterchecker.cpp<br />
src/core/tagsfilterchecker.h<br />
src/staticxml/staticxmlprovider.cpp<br />
tests/CMakeLists.txt<br />
tests/khotnewstuff_test.cpp<br />
tests/khotnewstuff_test.knsrc.in<br />
tests/knewstuff2_test.cpp<br />
tests/knewstuff2_test.h<br />
tests/knewstuff2_test.knsrc<br />
tests/testdata/entry.xml<br />
tests/testdata/provider.xml</div></div></div><br /><div><strong>To: </strong>leinir, KNewStuff, apol, KDE Store, whiting, ahiemstra, mlaurent<br /><strong>Cc: </strong>mlaurent, ngraham, ahiemstra, kde-frameworks-devel, KNewStuff, michaelh, ZrenBot, bruns<br /></div>