<table><tr><td style="">ngraham added a reviewer: Dolphin.<br />ngraham requested changes to this revision.<br />ngraham added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14360">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14360#inline-75740">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfileplaceeditdialog.cpp:123</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">m_iconButton</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KIconButton</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_iconButton</span><span style="color: #aa2211">-></span><span class="n">setVisible</span><span class="p">(</span><span class="n">url</span><span class="p">.</span><span class="n">scheme</span><span class="p">()</span> <span style="color: #aa2211">!=</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"trash"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">layout</span><span style="color: #aa2211">-></span><span class="n">addRow</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Choose an &icon:"</span><span class="p">),</span> <span class="n">m_iconButton</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">m_iconButton</span><span style="color: #aa2211">-></span><span class="n">setObjectName</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"icon button"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Let's also avoid adding the button to the layout in this case, just like you're doing in <a href="https://phabricator.kde.org/D14378" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D14378</a>.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14360">https://phabricator.kde.org/D14360</a></div></div><br /><div><strong>To: </strong>shubham, ngraham, broulik, Dolphin<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>