<table><tr><td style="">romangg accepted this revision.<br />romangg added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14291">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14291#inline-75356">View Inline</a><span style="color: #4b4d51; font-weight: bold;">remote_access_interface.cpp:244</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QObject</span><span style="color: #aa2211">::</span><span class="n">connect</span><span class="p">(</span><span class="n">rbuf</span><span class="p">,</span> <span style="color: #aa2211">&<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QObject</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">destroyed</span></span><span class="p">,</span> <span class="p">[</span><span class="n">p</span><span class="p">,</span> <span class="n">rbuf</span><span class="p">,</span> <span class="n">resource</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">bh</span><span class="p">]</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QObject</span><span style="color: #aa2211">::</span><span class="n">connect</span><span class="p">(</span><span class="n">rbuf</span><span class="p">,</span> <span style="color: #aa2211">&<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">Resource</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">aboutToBeUnbound</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">p</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">q</span></span><span class="p">,</span> <span class="p">[</span><span class="n">p</span><span class="p">,</span> <span class="n">rbuf</span><span class="p">,</span> <span class="n">resource</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">bh</span><span class="p">]</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">p</span><span style="color: #aa2211">-></span><span class="n">clientResources</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">resource</span><span class="p">))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why <tt style="background: #ebebeb; font-size: 13px;">p->q</tt>? Isn't just <tt style="background: #ebebeb; font-size: 13px;">p</tt> enough? Or since <tt style="background: #ebebeb; font-size: 13px;">getBufferCallback</tt> is static, leave the slot without object relation? Just connect to the functor as before. But in the end that all doesn't matter much.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14291#inline-75357">View Inline</a><span style="color: #4b4d51; font-weight: bold;">remote_access_interface.cpp:251</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">qCDebug</span><span class="p">(</span><span class="n">KWAYLAND_SERVER</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Remote buffer returned, client"</span> <span style="color: #aa2211"><<</span> <span class="n">wl_resource_get_id</span><span class="p">(</span><span class="n">resource</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211"><<</span> <span style="color: #766510">", id"</span> <span style="color: #aa2211"><<</span> <span class="n">rbuf</span><span style="color: #aa2211">-></span><span class="n">id</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211"><<</span> <span style="color: #766510">", fd"</span> <span style="color: #aa2211"><<</span> <span class="n">bh</span><span class="p">.</span><span class="n">buf</span><span style="color: #aa2211">-></span><span class="n">fd</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If the problem is only this call to id(), then maybe one could just hand over this value to the lambda instead of accessing <tt style="background: #ebebeb; font-size: 13px;">rbuf</tt>. But connecting to the <tt style="background: #ebebeb; font-size: 13px;">aboutToBeUnbound</tt> signal is also fine.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>BRANCH</strong><div><div>dave</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14291">https://phabricator.kde.org/D14291</a></div></div><br /><div><strong>To: </strong>davidedmundson, KWin, romangg<br /><strong>Cc: </strong>romangg, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>