<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14043">View Revision</a></tr></table><br /><div><div><p>This change broke KFilePlacesViewTest, please update that test as well.</p>

<p>$ bin/kfileplacesviewtest</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Start testing of KFilePlacesViewTest <strong>*</strong>****</li>
</ul>

<p>Config: Using QtTest library 5.11.1, Qt 5.11.1 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 5.3.1 20160301 [gcc-5-branch revision 233849])<br />
PASS   : KFilePlacesViewTest::initTestCase()<br />
PASS   : KFilePlacesViewTest::testUrlChanged(Today)<br />
PASS   : KFilePlacesViewTest::testUrlChanged(Yesterday)<br />
FAIL!  : KFilePlacesViewTest::testUrlChanged(Documents) Compared values are not the same</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Actual   (args.at(0).toUrl().toString()): "baloosearch:/documents"
Expected (expectedUrl)                  : "baloosearch:?json=%7B%22dayFilter%22: 0, %22monthFilter%22: 0, %22yearFilter%22: 0, %22type%22: [ %22Document%22]%7D"
Loc: [/d/kde/src/5/frameworks/kio/autotests/kfileplacesviewtest.cpp(114)]</pre></div>

<p>FAIL!  : KFilePlacesViewTest::testUrlChanged(Images) Compared values are not the same</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Actual   (args.at(0).toUrl().toString()): "baloosearch:/images"
Expected (expectedUrl)                  : "baloosearch:?json=%7B%22dayFilter%22: 0, %22monthFilter%22: 0, %22yearFilter%22: 0, %22type%22: [ %22Image%22]%7D"
Loc: [/d/kde/src/5/frameworks/kio/autotests/kfileplacesviewtest.cpp(114)]</pre></div>

<p>FAIL!  : KFilePlacesViewTest::testUrlChanged(Audio Files) Compared values are not the same</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Actual   (args.at(0).toUrl().toString()): "baloosearch:/audio"
Expected (expectedUrl)                  : "baloosearch:?json=%7B%22dayFilter%22: 0, %22monthFilter%22: 0, %22yearFilter%22: 0, %22type%22: [ %22Audio%22]%7D"
Loc: [/d/kde/src/5/frameworks/kio/autotests/kfileplacesviewtest.cpp(114)]</pre></div>

<p>FAIL!  : KFilePlacesViewTest::testUrlChanged(Videos) Compared values are not the same</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Actual   (args.at(0).toUrl().toString()): "baloosearch:/videos"
Expected (expectedUrl)                  : "baloosearch:?json=%7B%22dayFilter%22: 0, %22monthFilter%22: 0, %22yearFilter%22: 0, %22type%22: [ %22Video%22]%7D"
Loc: [/d/kde/src/5/frameworks/kio/autotests/kfileplacesviewtest.cpp(114)]</pre></div>

<p>PASS   : KFilePlacesViewTest::cleanupTestCase()<br />
Totals: 4 passed, 4 failed, 0 skipped, 0 blacklisted, 891ms</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Finished testing of KFilePlacesViewTest <strong>*</strong>****</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14043">https://phabricator.kde.org/D14043</a></div></div><br /><div><strong>To: </strong>broulik, Frameworks, bruns, dfaure, renatoo, franckarrecot, ngraham, hein<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>