<table><tr><td style="">jtamate updated this revision to Diff 38134.<br />jtamate marked 6 inline comments as done.<br />jtamate edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-jxmxvekwbzvhpns/">(Show Details)</a><br />jtamate added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12945">View Revision</a></tr></table><br /><div><div><p>Hopefully done all the requested changes.<br />
Passed uncristify-kf5.<br />
Removed the classes for simulating the filtering.<br />
Added benchmarks for 10, 100, 1000 and 10000 items.<br />
The items are inserted in the same random order for all the implementations.</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>The results in one machine<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">:</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> (in ms):<br />
<br />
| 10 itmes | QList | QListBinary | QMap | QHash |<br />
| add | 0.050 | 0.048 | 0.051 | 0.050 |<br />
|findByName | 0.0000057| 0.0000060 | 0.0000060 | 0.0000056 |<br />
|findByUrl | 0.0000056 | 0.0000060 | 0.0000059 | 0.0000059 |<br />
|findByUrlAll | 0.018 | 0.020 | 0.017 | 0.016 |</span><br />
<br />
| <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> | QList | QListBinary | QMap | QHash</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">100 itmes | QList | QListBinary | QMap | QHash |<br />
| add | 0.46 | 0.55 | 0.54 | 0.52 |<br />
|findByName | 0.0026 | 0.0013 | 0.0014 | 0.0031 |<br />
|findByUrl | 0.0028 | 0.0026 | 0.0024 | 0.0021 |<br />
|findByUrlAll | 0.57 | 0.22 | 0.199 | 0.17 |<br />
<br />
<br />
| 1000 itmes | QList | QListBinary | QMap | QHash |<br />
| add | 4.8 | 6.1 | 6.0 | 5.3 |<br />
|findByName | 0.037 | 0.0023 | 0.0022 | 0.16 </span> |<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">| add </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">|findByUrl</span> | <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> 18</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">0.030</span> | <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">21 | </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">0.0054 |</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> 24</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">0.0046 </span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> |</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">| </span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> 20 |</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">0.0038 |</span><br />
|findBy<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">Name | 937| 950 | 1.676 | 3.355 </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">UrlAll | 40 | 2.5 | 2.3 | 1.8 |<br />
<br />
| 10000 itmes | QList | QListBinary | QMap | QHash</span> |<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">|findByUrl</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">| add </span> | <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">1.953|</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> 47 | </span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> 14</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">69 </span> |<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> </span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> 14</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">68 </span> | <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> 9,7 |</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">53.0 |</span><br />
|findBy<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">UrlAll </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Name</span> | <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">692 | </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> 1.8 |</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> 11 </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">0.0034</span> |<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> </span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">0.0033</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">11 | 8,6 |</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> | 1.0 |</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">|AddNewItems</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">|findByUrl </span> | 1.<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">9 |</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">1 | </span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">2.0 </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">0.0084</span> | <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">0.0079</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">2.6 | 2,8 |</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">| 0.0062 |</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">|AddNewItemsV2 (only std::partition)| 1.3</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">|findByUrlAll | 4372 | </span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">|</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">33 </span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">1.3</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> |</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">|</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> </span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> 2.7</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">28 </span> | <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">3,0 |</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">21 |<br />
<br />
</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D12945?vs=35585&id=38134">https://phabricator.kde.org/D12945?vs=35585&id=38134</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12945">https://phabricator.kde.org/D12945</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/kcoredirlister_benchmark.cpp</div></div></div><br /><div><strong>To: </strong>jtamate, dfaure, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>