<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13808">View Revision</a></tr></table><br /><div><div><p>I just pushed the fix <a href="https://commits.kde.org/kxmlgui/d35a88289513c0420863b80aa6c1cb7d2c6e978f" class="remarkup-link" target="_blank" rel="noreferrer">https://commits.kde.org/kxmlgui/d35a88289513c0420863b80aa6c1cb7d2c6e978f</a><br />
Please continue working on the unittest here ;)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R263 KXmlGui</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13808">https://phabricator.kde.org/D13808</a></div></div><br /><div><strong>To: </strong>maxrd2, KDE Applications, dfaure, elvisangelaccio, broulik, cfeck<br /><strong>Cc: </strong>anthonyfieroni, arojas, marten, asturmlechner, wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns<br /></div>