<table><tr><td style="">rkflx accepted this revision.<br />rkflx added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14161">View Revision</a></tr></table><br /><div><div><p>Thanks for noticing, LGTM and restores the proper icon indeed.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>This was changed in <tt style="background: #ebebeb; font-size: 13px;">KMessageBox</tt> in <a href="https://phabricator.kde.org/R236:9b05a12a43dbe2b31a4655052f20de0832ac7a61" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">9b05a12a43dbe2b31a4655052f20de0832ac7a61</a> but never "upstreamed" to <tt style="background: #ebebeb; font-size: 13px;">KStyle</tt></p></blockquote>

<p>Sorry, did not know about this, and neither did the reviewer notice.</p>

<p>Should I submit Diffs (or commit directly?) where the wrong icon is still in use, e.g. <a href="https://lxr.kde.org/source/extragear/base/qtcurve/qt5/style/qtcurve.cpp#1001" class="remarkup-link" target="_blank" rel="noreferrer">here</a>, <a href="https://lxr.kde.org/source/extragear/base/qtcurve/qt5/style/qtcurve.cpp#1055" class="remarkup-link" target="_blank" rel="noreferrer">here</a>, <a href="https://lxr.kde.org/source/frameworks/kdelibs4support/src/kdeui/k4style.cpp#0489" class="remarkup-link" target="_blank" rel="noreferrer">here</a> and/or <a href="https://lxr.kde.org/source/playground/artwork/oxygen-transparent/style/oxygenstyle.cpp#8204" class="remarkup-link" target="_blank" rel="noreferrer">here</a>?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R252 Framework Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14161">https://phabricator.kde.org/D14161</a></div></div><br /><div><strong>To: </strong>broulik, dfaure, ngraham, rkflx<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>