<table><tr><td style="">gladhorn accepted this revision.<br />gladhorn added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14118">View Revision</a></tr></table><br /><div><div><p>I'd say make the casing consistent, otherwise it's a clear improvement in my opinion.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14118#inline-74697">View Inline</a><span style="color: #4b4d51; font-weight: bold;">containment.cpp:127</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">closeApplet</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">closeApplet</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"%1 is the name of the applet"</span><span class="p">,</span> <span style="color: #766510">"Remove this %1"</span><span class="p">,</span> <span class="n">title</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">closeApplet</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"%1 is the name of the applet"</span><span class="p">,</span> <span style="color: #766510">"Remove this %1<span class="bright"> widget</span>"</span><span class="p">,</span> <span class="n">title</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The translation help says applet, is widget or applet the better word? But actually the "add new" dialog in plasma says widget, so I'm for that for consistency reasons.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14118#inline-74696">View Inline</a><span style="color: #4b4d51; font-weight: bold;">applet_p.cpp:124</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">closeApplet</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">closeApplet</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"%1 is the name of the applet"</span><span class="p">,</span> <span style="color: #766510">"Remove this %1"</span><span class="p">,</span> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">title</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">closeApplet</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"%1 is the name of the applet"</span><span class="p">,</span> <span style="color: #766510">"Remove this %1<span class="bright"> Widget</span>"</span><span class="p">,</span> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">title</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This (Widget) is upper case (above it's lower case, which I prefer a tiny bit).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>BRANCH</strong><div><div>remove-this-widget (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14118">https://phabricator.kde.org/D14118</a></div></div><br /><div><strong>To: </strong>ngraham, Plasma, VDG, gladhorn<br /><strong>Cc: </strong>gladhorn, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>