<table><tr><td style="">pino requested changes to this revision.<br />pino added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14111">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14111#291934" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14111#291934</a>, <a href="https://phabricator.kde.org/p/kossebau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@kossebau</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14111#291933" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14111#291933</a>, <a href="https://phabricator.kde.org/p/pino/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@pino</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>NACK.<br />
Make sure that the request for shared-mime-info (<a href="https://bugs.freedesktop.org/show_bug.cgi?id=107227" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.freedesktop.org/show_bug.cgi?id=107227</a>) is accepted, and that is enough.</p></div>
</blockquote>
<p>Even if the request is accepted, it will take some time until it makes it to the users/developers, given smo 1.10 was tagged/released only some days ago, and as smo release cycle seems to be half a year or longer. Which in developer life is ages, especially looking at the web rivals, which deliver each months to everyone :/</p></div>
</blockquote>
<p>If that is problematic enough, talk with hadess (Bastien Nocera) about that.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>There is enough stuff in <tt style="background: #ebebeb; font-size: 13px;">kde5.xml</tt> already, even shipped in shared-mime-info, so adding more is not a good idea.</p></blockquote>
<p>Sure that needs some clean-up. I already started a patch to split this up and make things depend on the found smo version, so just the stuff is installed which is really needed.</p></blockquote>
<p>I thought about a similar approach in the past, but</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">unless you really maintain the amount of files, and properly tie each to a version of s-m-i, it becomes a mess to maintain</li>
<li class="remarkup-list-item">once you update s-m-i, you are back to a potential conflict (since the new s-m-i version may carry a new mimetype shipped in <tt style="background: #ebebeb; font-size: 13px;">kde5.xml</tt>)</li>
<li class="remarkup-list-item">related to the point above: s-m-i is really a <em>runtime</em> dependency, so version checks at <em>build</em> time are not exactly good ideas...</li>
</ul>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Perhaps you can reconsider your take on this one once that has been uploaded and reviewed :)</p></blockquote>
<p>Not really: even if you implement what you mention above, the duplication is still there.</p>
<p>Just to expand a bit more: when we switched to s-m-i during the kde4 development (more than 12 years ago), I took the task of migrating our mimetypes to the "new" format. Call it "mistakes of youth", "limitations of the toolchain at that point", etc, the result was a single <tt style="background: #ebebeb; font-size: 13px;">kde.xml</tt> carrying all the mimetype definitions that kdelibs had, and that s-m-i had not. Some of the mimetypes were generic enough to be added to s-m-i, so they were included (see various commits with myself as author), and some were not (see the various "smi rejected" comments floating around). To overcome the lack of these mimetypes in s-m-i, they were added in <tt style="background: #ebebeb; font-size: 13px;">kde.xml</tt>, because of the reasons you mention above. Soon though I realized it was not a good idea, since a) neither of the mimetypes were critical enough to warrant duplicates b) basically nobody else than <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> me maintained <tt style="background: #ebebeb; font-size: 13px;">kde.xml</tt>. See for example the recent <a href="https://phabricator.kde.org/R244:e5f09f84a945af4edf4f346aed409acf29905414" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">e5f09f84a945af4edf4f346aed409acf29905414</a>, which is one of the biggest cleanups after so many years. Or <a href="https://phabricator.kde.org/R244:a7be6bab411d7f1fe2555ab5adc0465ca0cfc5d9" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">a7be6bab411d7f1fe2555ab5adc0465ca0cfc5d9</a>, i.e. synchronize a local copy of a s-m-i mimetype ...</p>
<p>So yes, I understand your reasons, but because of all the history involved I really do not want to add more stuff to <tt style="background: #ebebeb; font-size: 13px;">kde5.xml</tt> that is really material for s-m-i.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14111">https://phabricator.kde.org/D14111</a></div></div><br /><div><strong>To: </strong>kossebau, dfaure, pino<br /><strong>Cc: </strong>fabianr, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>