<table><tr><td style="">michaeleden updated this revision to Diff 37301.<br />michaeleden added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13670">View Revision</a></tr></table><br /><div><div><p>Respond to <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> comments by adding tests and separating subseq func</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R309 KService</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D13670?vs=36493&id=37301">https://phabricator.kde.org/D13670?vs=36493&id=37301</a></div></div><br /><div><strong>BRANCH</strong><div><div>feature/match-subseq</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13670">https://phabricator.kde.org/D13670</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/CMakeLists.txt<br />
autotests/kservicetest.cpp<br />
autotests/kservicetest.h<br />
src/services/ktraderparse.cpp<br />
src/services/ktraderparse_p.h<br />
src/services/ktraderparsetree.cpp<br />
src/services/ktraderparsetree_p.h<br />
src/services/lex.l<br />
src/services/yacc.y</div></div></div><br /><div><strong>To: </strong>michaeleden, dfaure, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>