<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13670">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13670#inline-73479">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ktraderparsetree.cpp:443</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">Iterator</span> <span class="n">i</span> <span style="color: #aa2211">=</span> <span class="n">c2</span><span class="p">.</span><span class="n">str</span><span class="p">.</span><span class="n">begin</span><span class="p">(),</span> <span class="n">j</span> <span style="color: #aa2211">=</span> <span class="n">c1</span><span class="p">.</span><span class="n">str</span><span class="p">.</span><span class="n">begin</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">for</span> <span class="p">(;</span> <span class="n">i</span> <span style="color: #aa2211">!=</span> <span class="n">c2</span><span class="p">.</span><span class="n">str</span><span class="p">.</span><span class="n">end</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">j</span> <span style="color: #aa2211"><</span> <span class="n">c1</span><span class="p">.</span><span class="n">str</span><span class="p">.</span><span class="n">end</span><span class="p">();</span> <span style="color: #aa2211">++</span><span class="n">i</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Nothing is being modified, so this should use constBegin(), constEnd(), and const_iterator.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13670#inline-73481">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ktraderparsetree.cpp:444</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">Iterator</span> <span class="n">i</span> <span style="color: #aa2211">=</span> <span class="n">c2</span><span class="p">.</span><span class="n">str</span><span class="p">.</span><span class="n">begin</span><span class="p">(),</span> <span class="n">j</span> <span style="color: #aa2211">=</span> <span class="n">c1</span><span class="p">.</span><span class="n">str</span><span class="p">.</span><span class="n">begin</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">for</span> <span class="p">(;</span> <span class="n">i</span> <span style="color: #aa2211">!=</span> <span class="n">c2</span><span class="p">.</span><span class="n">str</span><span class="p">.</span><span class="n">end</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">j</span> <span style="color: #aa2211"><</span> <span class="n">c1</span><span class="p">.</span><span class="n">str</span><span class="p">.</span><span class="n">end</span><span class="p">();</span> <span style="color: #aa2211">++</span><span class="n">i</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">((</span><span class="n">chk_case</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">*</span><span class="n">i</span> <span style="color: #aa2211">==</span> <span style="color: #aa2211">*</span><span class="n">j</span><span class="p">)</span> <span style="color: #aa2211">||</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">chk_case</span> <span style="color: #aa2211">&&</span> <span class="n">i</span><span style="color: #aa2211">-></span><span class="n">toLower</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">j</span><span style="color: #aa2211">-></span><span class="n">toLower</span><span class="p">()))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This code (the actual algorithm) should be extracted into a function, and a unittest should be written for it (to make sure all corner cases are correctly handled).</p>

<p style="padding: 0; margin: 8px;">Good opportunity to document the kind of matching being done, too, as you had to explain to me in this review request.</p>

<p style="padding: 0; margin: 8px;">And then once this commit is in, it should be documented on <a href="https://techbase.kde.org/Development/Tutorials/Services/Traders" class="remarkup-link" target="_blank" rel="noreferrer">https://techbase.kde.org/Development/Tutorials/Services/Traders</a>, please remember to do so.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R309 KService</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13670">https://phabricator.kde.org/D13670</a></div></div><br /><div><strong>To: </strong>michaeleden, dfaure, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>