<table><tr><td style="">dhaumann accepted this revision.<br />dhaumann added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13635">View Revision</a></tr></table><br /><div><div><p>I'll give the OK, but please increase kateversion to 5.0 first.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13635#inline-73407">View Inline</a><span style="color: #4b4d51; font-weight: bold;">javadoc.xml:3</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96"><!DOCTYPE language SYSTEM "language.dtd"></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #00702a"><language</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Javadoc"</span> <span style="color: #354bb3">version=</span><span style="color: #766510">"<span class="bright">2</span>"</span> <span style="color: #354bb3">kateversion=</span><span style="color: #766510">"2.4"</span> <span style="color: #354bb3">section=</span><span style="color: #766510">"Markup"</span> <span style="color: #354bb3">extensions=</span><span style="color: #766510">""</span> <span style="color: #354bb3">license=</span><span style="color: #766510">"LGPL"</span> <span style="color: #354bb3">author=</span><span style="color: #766510">"Alfredo Luiz Foltran Fialho (alfoltran@ig.com.br)"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #00702a"><language</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Javadoc"</span> <span style="color: #354bb3">version=</span><span style="color: #766510">"<span class="bright">3</span>"</span> <span style="color: #354bb3">kateversion=</span><span style="color: #766510">"2.4"</span> <span style="color: #354bb3">section=</span><span style="color: #766510">"Markup"</span> <span style="color: #354bb3">extensions=</span><span style="color: #766510">""</span> <span style="color: #354bb3">license=</span><span style="color: #766510">"LGPL"</span> <span style="color: #354bb3">author=</span><span style="color: #766510">"Alfredo Luiz Foltran Fialho (alfoltran@ig.com.br)"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #00702a"><highlighting></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">kateversion="5.0", since you use dsAnnotation (iirc).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13635">https://phabricator.kde.org/D13635</a></div></div><br /><div><strong>To: </strong>vkrause, dhaumann<br /><strong>Cc: </strong>dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>