<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13808">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13808#inline-73207">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmainwindow_unittest.cpp:265</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">NativeMainWindow</span> <span style="color: #aa2211">*</span><span class="n">mw</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">NativeMainWindow</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">connect</span><span class="p">(</span><span class="n">mw</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QObject</span><span style="color: #aa2211">::</span><span class="n">destroyed</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa2211">&</span><span class="p">](</span><span class="n">QObject</span> <span style="color: #aa2211">*</span><span class="p">){</span> <span class="n">el</span><span class="p">.</span><span class="n">exit</span><span class="p">();</span> <span class="p">});</span> <span style="color: #74777d">// quit event loop when window's gone</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">connect(mw, &QObject::destroyed, &el, &QEventLoop::quit);</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13808#inline-73206">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmainwindow_unittest.cpp:267</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QApplication</span><span style="color: #aa2211">::</span><span class="n">postEvent</span><span class="p">(</span><span class="n">mw</span><span class="p">,</span> <span style="color: #aa4000">new</span> <span class="n">QDeferredDeleteEvent</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">mw->deleteLater()</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13808#inline-73204">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmainwindow_unittest.cpp:278</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">el</span><span class="p">.</span><span class="n">processEvents</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QVERIFY</span><span class="p">(</span><span class="n">mw</span><span style="color: #aa2211">-></span><span class="n">m_dock</span><span style="color: #aa2211">-></span><span class="n">isVisible</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #304a96">true</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">mw</span><span style="color: #aa2211">-></span><span class="n">m_dock</span><span style="color: #aa2211">-></span><span class="n">hide</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">QCOMPARE(mw->m-dock->isVisible(), true)</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R263 KXmlGui</div></div></div><br /><div><strong>BRANCH</strong><div><div>fix-window-state-save</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13808">https://phabricator.kde.org/D13808</a></div></div><br /><div><strong>To: </strong>maxrd2, KDE Applications, dfaure, elvisangelaccio, broulik, cfeck<br /><strong>Cc: </strong>wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns<br /></div>