<table><tr><td style="">rjvbb updated this revision to Diff 37000.<br />rjvbb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13777">View Revision</a></tr></table><br /><div><div><p>KThemeSettings moved to its own header+implementation files, and extended so different groups can be read. I don't think it needs much else in terms of functionality or complexity, if anything. There's no point in exporting it anyway (so it has a very specific target audience).</p>
<p>Let's please do most of the preparatory work here so I don't have to juggle more than 1 review/diff that concerns multiple files in the same directory for longer than strictly necessary.</p></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D13777?vs=36943&id=37000">https://phabricator.kde.org/D13777?vs=36943&id=37000</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13777">https://phabricator.kde.org/D13777</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/CMakeLists.txt<br />
src/kmessagewidget.cpp<br />
src/kthemesettings.cpp<br />
src/kthemesettings_p.h</div></div></div><br /><div><strong>To: </strong>rjvbb, ngraham, Frameworks<br /><strong>Cc: </strong>cfeck, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>