<table><tr><td style="">elvisangelaccio requested changes to this revision.<br />elvisangelaccio added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13805">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13805#inline-72873">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knewfilemenu.cpp:860</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Test to see if the user has given "." or ".." as a name</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">name</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"."</span> <span style="color: #aa2211">||</span> <span class="n">name</span> <span style="color: #aa2211">==</span> <span style="color: #766510">".."</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KGuiItem</span> <span class="n">cancelGuiItem</span><span class="p">(</span><span class="n">KStandardGuiItem</span><span style="color: #aa2211">::</span><span class="n">cancel</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please use <tt style="background: #ebebeb; font-size: 13px;">QLatin1String</tt> here, which is faster for string comparisons.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13805#inline-72875">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knewfilemenu.cpp:874</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">createKMessageBox</span><span class="p">(</span><span class="n">confirmDialog</span><span class="p">,</span> <span class="n">buttonBox</span><span class="p">,</span> <span class="n">QMessageBox</span><span style="color: #aa2211">::</span><span class="n">Critical</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Folder </span><span style="color: #bb6622">\"</span><span style="color: #766510">%1</span><span style="color: #bb6622">\"</span><span style="color: #766510"> could not be created:</span><span style="color: #bb6622">\n\"</span><span style="color: #766510">%1</span><span style="color: #bb6622">\"</span><span style="color: #766510"> is reserved for use by the operating system."</span><span class="p">,</span> <span class="n">name</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringList</span><span class="p">(),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please use semantic markup here: <a href="https://api.kde.org/frameworks/ki18n/html/prg_guide.html#kuit_markup" class="remarkup-link" target="_blank" rel="noreferrer">https://api.kde.org/frameworks/ki18n/html/prg_guide.html#kuit_markup</a></p>
<p style="padding: 0; margin: 8px;">tl;dr use <tt style="background: #ebebeb; font-size: 13px;"><filename>%1</filename></tt> instead of <tt style="background: #ebebeb; font-size: 13px;">\"%1\"</tt> and <tt style="background: #ebebeb; font-size: 13px;"><nl/></tt> instead of <tt style="background: #ebebeb; font-size: 13px;">\n</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13805#inline-72872">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knewfilemenu.cpp:876</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringList</span><span class="p">(),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">""</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">nullptr</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please use <tt style="background: #ebebeb; font-size: 13px;">QString()</tt> here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13805#inline-72871">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knewfilemenu.cpp:884</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">confirmDialog</span><span style="color: #aa2211">-></span><span class="n">show</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_text</span> <span style="color: #aa2211">=</span> <span style="color: #766510">""</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">m_text = QString()</tt>, like we already do in <tt style="background: #ebebeb; font-size: 13px;">_k_slotAbortDialog()</tt>.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13805">https://phabricator.kde.org/D13805</a></div></div><br /><div><strong>To: </strong>tmarshall, Dolphin, Frameworks, ngraham, dfaure, elvisangelaccio<br /><strong>Cc: </strong>cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, kde-frameworks-devel, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp<br /></div>