<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13777">View Revision</a></tr></table><br /><div><div><p>Thanks, I think this approach is more feasible! I have some comments below:</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13777#inline-72493">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmessagewidget.cpp:275</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// for best results.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">//     const QColor windowColor = KMessageWidget::palette().window().color();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">QColor</span> <span class="n">windowColor</span> <span style="color: #aa2211">=</span> <span class="n">palette</span><span class="p">.</span><span class="n">window</span><span class="p">().</span><span class="n">color</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This commented-out line and its comments should be removed.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13777#inline-72495">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmessagewidget.cpp:311</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">qreal</span> <span class="n">windowIntensity</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0.299</span> <span style="color: #aa2211">*</span> <span class="n">windowColor</span><span class="p">.</span><span class="n">redF</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #601200">0.586</span> <span style="color: #aa2211">*</span> <span class="n">windowColor</span><span class="p">.</span><span class="n">greenF</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #601200">0.115</span> <span style="color: #aa2211">*</span> <span class="n">windowColor</span><span class="p">.</span><span class="n">blueF</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">bgBaseColorAlpha</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0.5</span> <span style="color: #aa2211">*</span> <span class="n">qMax</span><span class="p">((</span><span class="n">bgIntensity</span> <span style="color: #aa2211">+</span> <span class="p">(</span><span style="color: #601200">1</span> <span style="color: #aa2211">-</span> <span class="n">windowIntensity</span><span class="p">)),</span> <span class="n">bgIntensity</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">break</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't think all of this complicated code is necessary. The theme itself is supposed to ensure readability with the colors that it uses. Also, this results in a slight regression for the Breeze Dark theme: the Information widget doesn't get enough alpha and is too bright, worsening readability compared to the status quo.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R236 KWidgetsAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13777">https://phabricator.kde.org/D13777</a></div></div><br /><div><strong>To: </strong>rjvbb, ngraham, Frameworks<br /><strong>Cc: </strong>cfeck, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>