<table><tr><td style="">vandenoever accepted this revision.<br />vandenoever added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13719">View Revision</a></tr></table><br /><div><div><p>Good fixes. Just some small naming suggestions.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13719#inline-71955">View Inline</a><span style="color: #4b4d51; font-weight: bold;">odfextractor.cpp:37</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">QDomElement</span> <span class="n">namedItemNS</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QDomNode</span> <span style="color: #aa2211">&</span><span class="n">node</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">nsURI</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">localName</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Perhaps name this <tt style="background: #ebebeb; font-size: 13px;">elementByTagNameNS</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13719#inline-71954">View Inline</a><span style="color: #4b4d51; font-weight: bold;">odfextractor.cpp:39</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">auto</span> <span class="n">n</span> <span style="color: #aa2211">=</span> <span class="n">node</span><span class="p">.</span><span class="n">firstChildElement</span><span class="p">();</span> <span style="color: #aa2211">!</span><span class="n">n</span><span class="p">.</span><span class="n">isNull</span><span class="p">();</span> <span class="n">n</span> <span style="color: #aa2211">=</span> <span class="n">n</span><span class="p">.</span><span class="n">nextSiblingElement</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">n</span><span class="p">.</span><span class="n">localName</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">localName</span> <span style="color: #aa2211">&&</span> <span class="n">n</span><span class="p">.</span><span class="n">namespaceURI</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">nsURI</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Variable name <tt style="background: #ebebeb; font-size: 13px;">e</tt> for element is more logical.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>BRANCH</strong><div><div>noncommonprefixodf</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13719">https://phabricator.kde.org/D13719</a></div></div><br /><div><strong>To: </strong>kossebau, vandenoever<br /><strong>Cc: </strong>kde-frameworks-devel, Baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>