<table><tr><td style="">gregormi added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13706">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13706#inline-71881">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmoretoolspresets.cpp:59</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">//</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">ADD_ENTRY</span><span class="p">(</span><span style="color: #766510">"angrysearch"</span><span class="p">,</span>                        <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #766510">"https://github.com/DoTheEvo/ANGRYsearch"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">ADD_ENTRY</span><span class="p">(</span><span style="color: #766510">"com.uploadedlobster.peek"</span><span class="p">,</span>           <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #766510">"https://github.com/phw/peek"</span><span class="p">);</span> <span style="color: #74777d">// easy to use screen recorder, creates gif</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">ADD_ENTRY</span><span class="p">(</span><span style="color: #766510">"angrysearch"</span><span class="p">,</span>                        <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #766510">"https://github.com/DoTheEvo/ANGRYsearch"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">""</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">ADD_ENTRY</span><span class="p">(</span><span style="color: #766510">"com.uploadedlobster.peek"</span><span class="p">,</span>           <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #766510">"https://github.com/phw/peek"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">""</span></span><span class="p">);</span> <span style="color: #74777d">// easy to use screen recorder, creates gif</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I have these thoughts when I see the ADD_ENTRY lines:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">Appstream data is _the_ important source of app data. So I would move it directly after the URL count and before the homepage</li>
</ol>

<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">Mostly, desktopEntryName and appstreamComponentId are equal. So, maybe one could use a placeholder (e.g. ~) to reuse the desktopEntryName</li>
</ol>

<p style="padding: 0; margin: 8px;">ADD_ENTRY("catfish", 1, "<a href="http://www.twotoasts.de/index.php/catfish/"" class="remarkup-link" target="_blank" rel="noreferrer">http://www.twotoasts.de/index.php/catfish/"</a>, "appstream://catfish");<br />
would become<br />
ADD_ENTRY("catfish", 1, "~", "<a href="http://www.twotoasts.de/index.php/catfish/"" class="remarkup-link" target="_blank" rel="noreferrer">http://www.twotoasts.de/index.php/catfish/"</a>);</p>

<p style="padding: 0; margin: 8px;">ADD_ENTRY("giggle", 1, "<a href="https://wiki.gnome.org/Apps/giggle/"" class="remarkup-link" target="_blank" rel="noreferrer">https://wiki.gnome.org/Apps/giggle/"</a>, "appstream://giggle.desktop");<br />
would become<br />
ADD_ENTRY("giggle", 1, "giggle.desktop", "<a href="https://wiki.gnome.org/Apps/giggle/"" class="remarkup-link" target="_blank" rel="noreferrer">https://wiki.gnome.org/Apps/giggle/"</a>);</p>

<p style="padding: 0; margin: 8px;">But in the end this is only cosmetics and not required to land this patch.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13706">https://phabricator.kde.org/D13706</a></div></div><br /><div><strong>To: </strong>nicolasfella, Frameworks, gregormi, dhaumann<br /><strong>Cc: </strong>dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>