<table><tr><td style="">habacker added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13406">View Revision</a></tr></table><br /><div><div><p>The macro file uses something like`set(_ki18n_uic_script ${CMAKE_CURRENT_LIST_DIR}/kf5i18nuic.cmake) ` for two variables, saying that the referenced files are located beside the macro file, but the remaining files are based surprisely on a complete different variable, hiding where the related files are located really. This patches cleans up this by moving all related files into the build dir, which looks more clean to me. For installing local translations it is only required to add <build-dir>/cmake to use the macro file and for autotests/ki18n_install.</p>
<p>Furthermore KF5I18n_DIR seems to be required to support autotests/ki18n_install, which is a client package using a non standard way to use the macro file from an partially installed ki18n package (some files from <build-root>/cmake and some from <src-root>/cmake) , where it would be much more standard to use a full 'find_package' call inside (<a href="https://cgit.kde.org/ki18n.git/tree/autotests/ki18n_install/CMakeLists.txt" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/ki18n.git/tree/autotests/ki18n_install/CMakeLists.txt</a>) only from <build-root>/cmake e.g.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">project(ki18n_install)
cmake_minimum_required(VERSION 3.0)
find_package(KF5I18N)
ki18n_install(${CMAKE_CURRENT_SOURCE_DIR}/po)</pre></div>
<p>BTW: I was faced to this on trying to understand the ki1i8n build system, from which I took the macro file and all related dependencies to install po files from a tarball released by KDE for a cross build umbrello for Windows (see <a href="https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-umbrello" class="remarkup-link" target="_blank" rel="noreferrer">https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-umbrello</a>), which cant use the full KI18n package for now.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R249 KI18n</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13406">https://phabricator.kde.org/D13406</a></div></div><br /><div><strong>To: </strong>habacker, ilic<br /><strong>Cc: </strong>cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>