<table><tr><td style="">zzag created this revision.<br />zzag added reviewers: Plasma, Frameworks.<br />Restricted Application added a project: Frameworks.<br />Restricted Application added a subscriber: kde-frameworks-devel.<br />zzag requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13402">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">hintXXXMargin</span> <span style="color: #aa2211">></span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">)</span> <span class="p">{</span>
    <span style="color: #74777d">// ...</span>
<span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
    <span style="color: #74777d">// ...</span>
<span class="p">}</span></pre></div>

<p>are redundant because fixedXXXMargin already hold correct margin values.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Manually</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>BRANCH</strong><div><div>framesvg-simplify-updatesizes</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13402">https://phabricator.kde.org/D13402</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/plasma/framesvg.cpp</div></div></div><br /><div><strong>To: </strong>zzag, Plasma, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>