<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13384">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D13384#275224" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D13384#275224</a>, <a href="https://phabricator.kde.org/p/zzag/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@zzag</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Corner case: what if only need to update cachedBackground(i.e. enabledBorders and frameSize are okay)?</p></div>
</blockquote>

<p>Delete <tt style="background: #ebebeb; font-size: 13px;">shouldUpdate</tt> and wrap if (refcount() == 1) {} into another if statement, e.g.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">maskFrame</span><span style="color: #aa2211">-></span><span class="n">enabledBorders</span> <span style="color: #aa2211">!=</span> <span class="n">frame</span><span style="color: #aa2211">-></span><span class="n">enabledBorders</span> <span style="color: #aa2211">||</span> <span class="n">maskFrame</span><span style="color: #aa2211">-></span><span class="n">frameSize</span> <span style="color: #aa2211">!=</span> <span class="n">frameSize</span><span class="p">(</span><span class="n">frame</span><span class="p">))</span> <span class="p">{</span>
    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">maskFrame</span><span style="color: #aa2211">-></span><span class="n">refcount</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span><span class="p">)</span> <span class="p">{</span>
        <span style="color: #74777d">// ...</span>
    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
        <span style="color: #74777d">// ...</span>
    <span class="p">}</span>
    <span class="n">updateSizes</span><span class="p">(</span><span class="n">maskFrame</span><span class="p">);</span>
<span class="p">}</span>

<span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">maskFrame</span><span style="color: #aa2211">-></span><span class="n">cachedBackground</span><span class="p">.</span><span class="n">isNull</span><span class="p">())</span> <span class="p">{</span>
    <span class="n">generateBackground</span><span class="p">(</span><span class="n">maskFrame</span><span class="p">);</span>
<span class="p">}</span>

<span style="color: #aa4000">return</span> <span class="n">maskFrame</span><span style="color: #aa2211">-></span><span class="n">cachedBackground</span><span class="p">;</span></pre></div>

<p>?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13384">https://phabricator.kde.org/D13384</a></div></div><br /><div><strong>To: </strong>zzag, Plasma, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>