<table><tr><td style="">jtamate updated this revision to Diff 35585.<br />jtamate edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-ocncmmkzw45p7df/">(Show Details)</a><br />jtamate added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12945">View Revision</a></tr></table><br /><div><div><p>Changed the structure QListBinaryHash to QMap<br />
Changed from KFileItems pointers to Values (it caused memory problems).</p>
<p>Imported the parts that handle the filters to do the benchmarks of addNewItems.<br />
Assume KFileItems has < operands.</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;">Decide which data structure is best for kcoredirlister lstItems.<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">Defined as NonMovableFileItemList lstItems; </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
The results</span> in <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">kcoredirlister_p.h (484).</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">one machine:</span><br />
<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">The results in one machine:<br />
<br />
| | QList | QListBinary | QListBinaryHash | QHash</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">| | QList | QListBinary | QMap | QHash |<br />
| add | 18 | 21 | 24 | 20 </span> |<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">| add </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">|findByName</span> | <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">17 | </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">937|</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">35 |</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">950 </span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">|</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> 20 </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">1.676</span> | <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> 18 </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">3.355</span> |<br />
|findBy<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">Name | 937|</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Url | 1.953| </span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">969</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> 14</span> | <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">1.326</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> 14</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> | 1.626 |</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">| 9,7 |</span><br />
|findByUrl<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">All</span> | <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">1.953|</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> 692</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">|</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">66</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> | </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">11 |</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">7,6</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> | </span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">11 |</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">7,2 |</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">8,6 |</span><br />
|<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">findByUrlAll| 692 | 25 | 8,2 | 8,0 |<br />
<br />
</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">AddNewItems | 1.9 | 2.0 | 2.6 | 2,8 |<br />
|AddNewItemsV2 (only std::partition)| 1.3 | 1.3 | 2.7 | 3,0 |</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D12945?vs=34368&id=35585">https://phabricator.kde.org/D12945?vs=34368&id=35585</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12945">https://phabricator.kde.org/D12945</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/CMakeLists.txt<br />
autotests/kcoredirlister_benchmark.cpp</div></div></div><br /><div><strong>To: </strong>jtamate, dfaure, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>