<table><tr><td style="">sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13327">View Revision</a></tr></table><br /><div><div><p><tt style="background: #ebebeb; font-size: 13px;">-DQT_NO_CAST_FROM_BYTEARRAY</tt> is a default define from <tt style="background: #ebebeb; font-size: 13px;">KDEFrameworkCompilerSettings.cmake</tt>, so kdnssd should be working. The reason it wasn't is likely because most/all distributions build with avahi. Additionally, build.kde.org seems to build without avahi and dnssd, so it doesn't validate half the code at all 😒</p>

<p>With all that said, the change looks good.</p>

<p><a href="https://doc.qt.io/qt-5/qtglobal.html#qUtf8Printable" class="remarkup-link" target="_blank" rel="noreferrer">qUtf8Printable</a> might be nicer to read than <tt style="background: #ebebeb; font-size: 13px;">qString.toUtf8().constData()</tt> though, might be worth thinking about.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13327#inline-69416">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mdnsd-publicservice.cpp:163</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">for</span> <span class="p">(</span><span class="n">QMap</span><span style="color: #aa2211"><</span><span class="n">QString</span><span class="p">,</span> <span class="n">QByteArray</span><span style="color: #aa2211">>::</span><span class="n">ConstIterator</span> <span class="n">it</span> <span style="color: #aa2211">=</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_textData</span><span class="p">.</span><span class="n">cbegin</span><span class="p">();</span> <span class="n">it</span> <span style="color: #aa2211">!=</span> <span class="n">itEnd</span><span class="p">;</span> <span style="color: #aa2211">++</span><span class="n">it</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">TXTRecordSetValue</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">txt</span><span class="p">,</span> <span class="n">it</span><span class="p">.</span><span class="n">key</span><span class="p">().</span><span class="n">toUtf8</span><span class="p">(),</span> <span class="n">it</span><span class="p">.</span><span class="n">value</span><span class="p">().</span><span class="n">length</span><span class="p">(),</span> <span class="n">it</span><span class="p">.</span><span class="n">value</span><span class="p">())</span> <span style="color: #aa2211">!=</span> <span class="n">kDNSServiceErr_NoError</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">TXTRecordSetValue</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">txt</span><span class="p">,</span> <span class="n">it</span><span class="p">.</span><span class="n">key</span><span class="p">().</span><span class="n">toUtf8</span><span class="p">()<span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">constData</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>,</span> <span class="n">it</span><span class="p">.</span><span class="n">value</span><span class="p">().</span><span class="n">length</span><span class="p">(),</span> <span class="n">it</span><span class="p">.</span><span class="n">value<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span class="n"><span class="bright">data</span></span><span class="p">())</span> <span style="color: #aa2211">!=</span> <span class="n">kDNSServiceErr_NoError</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">TXTRecordDeallocate</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">txt</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is there a reason the second call is going to <tt style="background: #ebebeb; font-size: 13px;">data()</tt> rather than <tt style="background: #ebebeb; font-size: 13px;">constData()</tt>? There is <tt style="background: #ebebeb; font-size: 13px;">const char *data() const</tt> so it ultimately makes no difference, for code expressiveness I would say all calls should be to <tt style="background: #ebebeb; font-size: 13px;">constData()</tt> though.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R272 KDNSSD</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13327">https://phabricator.kde.org/D13327</a></div></div><br /><div><strong>To: </strong>adridg<br /><strong>Cc: </strong>sitter, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>