<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13285">View Revision</a></tr></table><br /><div><div><p>I'm not sure whether that's a good idea to use QMargins for measures, maybe, it would be better to have something like</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">struct</span> <span class="p">{</span>
    <span class="n">QSize</span> <span class="n">left</span><span class="p">;</span>
    <span class="n">QSize</span> <span class="n">top</span><span class="p">;</span>
    <span class="n">QSize</span> <span class="n">right</span><span class="p">;</span>
    <span class="n">QSize</span> <span class="n">bottom</span><span class="p">;</span>
<span class="p">}</span> <span class="n">sizes</span><span class="p">,</span> <span class="n">fixedSizes</span><span class="p">;</span></pre></div>

<p>in FrameData, which then should go in a different diff (if you think it's worth it).</p>

<p>Also, I think it will simplify generateFrameBackground a little bit, e.g.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">paintBorder</span><span class="p">(</span><span class="n">p</span><span class="p">,</span> <span class="n">frame</span><span class="p">,</span> <span class="n">FrameSvg</span><span style="color: #aa2211">::</span><span class="n">RightBorder</span><span class="p">,</span> <span class="n">frame</span><span style="color: #aa2211">-></span><span class="n">sizes</span><span class="p">.</span><span class="n">right</span> <span style="color: #aa2211">*</span> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">devicePixelRatio</span><span class="p">,</span> <span class="n">contentRect</span><span class="p">);</span></pre></div>

<p>so there won't be a need for <tt style="background: #ebebeb; font-size: 13px;">const int leftHeight = q->elementSize(frame->prefix % QLatin1String("left")).height();</tt></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13285">https://phabricator.kde.org/D13285</a></div></div><br /><div><strong>To: </strong>zzag, Plasma, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>