<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13215">View Revision</a></tr></table><br /><div><div><p>Answer to my inline question: updateSizes can be omitted (but I would prefer to leave it). Also, <tt style="background: #ebebeb; font-size: 13px;">maskFrame->enabledBorders = frame->enabledBorders;</tt> above is redundant (maskFrame->enabledBorders is already equal to frame->enabledBorders; it if wasn't the case, then cacheId works incorrectly or FrameData constructor doesn't copy enabledBorders, which isn't the case).</p>

<p>Also,</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">s_sharedFrames</span><span class="p">[</span><span class="n">q</span><span style="color: #aa2211">-></span><span class="n">theme</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">d</span><span class="p">].</span><span class="n">contains</span><span class="p">(</span><span class="n">oldKey</span><span class="p">))</span> <span class="p">{</span>
    <span class="n">s_sharedFrames</span><span class="p">[</span><span class="n">q</span><span style="color: #aa2211">-></span><span class="n">theme</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">d</span><span class="p">].</span><span class="n">remove</span><span class="p">(</span><span class="n">oldKey</span><span class="p">);</span>
    <span class="n">s_sharedFrames</span><span class="p">[</span><span class="n">q</span><span style="color: #aa2211">-></span><span class="n">theme</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">d</span><span class="p">].</span><span class="n">insert</span><span class="p">(</span><span class="n">newKey</span><span class="p">,</span> <span class="n">maskFrame</span><span class="p">);</span>
<span class="p">}</span></pre></div>

<p>ignores refcount, which may cause problems. I won't fix that, because that would be unrelated change.</p>

<p>Yet another "also":</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">maskFrame</span><span style="color: #aa2211">-></span><span class="n">cachedBackground</span><span class="p">.</span><span class="n">isNull</span><span class="p">())</span> <span class="p">{</span>
    <span style="color: #aa4000">return</span> <span class="n">QPixmap</span><span class="p">();</span>
<span class="p">}</span></pre></div>

<p>is redundant.</p>

<p>Anyway, I think I finished my work on fixing bugs that are listed in the summary and would like to proceed with review.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13215">https://phabricator.kde.org/D13215</a></div></div><br /><div><strong>To: </strong>zzag, Plasma, Frameworks<br /><strong>Cc: </strong>abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>