<table><tr><td style="">nicolasfella added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12895">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12895#inline-68090">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sharefileitemaction.cpp:83</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_purposeMenu</span><span style="color: #aa2211">-></span><span class="n">model</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setInputData</span><span class="p">(</span><span class="n">QJsonObject</span><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">{</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"mimeType"</span><span class="p">),</span> <span class="n">fileItemInfos</span><span class="p">.</span><span class="n">mimeType</span><span class="p">()},</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">{</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"urls"</span><span class="p">),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">mimeType() can be empty which can cause problems (see <a href="https://phabricator.kde.org/D12728" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D12728</a>). Not sure if it will here though</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12895#inline-68089">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sharefileitemaction.cpp:91</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QAction</span> <span style="color: #aa2211">*</span><span class="n">menuAction</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QAction</span><span class="p">(</span><span class="n">QIcon</span><span style="color: #aa2211">::</span><span class="n">fromTheme</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"document-share"</span><span class="p">)),</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"Share file"</span><span class="p">,</span> <span style="color: #766510">"Share"</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">menuAction</span><span style="color: #aa2211">-></span><span class="n">setMenu</span><span class="p">(</span><span class="n">m_purposeMenu</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can use m_purposeMenu->menuAction()</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R495 Purpose Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12895">https://phabricator.kde.org/D12895</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG, apol<br /><strong>Cc: </strong>nicolasfella, elvisangelaccio, abetts, ngraham, kde-frameworks-devel, michaelh, bruns<br /></div>