<table><tr><td style="">maximilianocuria added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13018">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D13018#266137" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D13018#266137</a>, <a href="https://phabricator.kde.org/p/elvisangelaccio/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@elvisangelaccio</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Hmm, still seems to fail here:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ ctest -R kfileplacesmodeltest</span>
<span style="color: #808080">Test project /home/elvis/dev/kde/kio/local-build</span>
<span style="color: #808080"> Start 50: kiofilewidgets-kfileplacesmodeltest</span>
<span style="color: #808080">1/1 Test #50: kiofilewidgets-kfileplacesmodeltest ...***Failed 0.60 sec</span>
<span style="color: #808080">********* Start testing of KFilePlacesModelTest *********</span>
<span style="color: #808080">Config: Using QtTest library 5.11.0, Qt 5.11.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 8.1.0)</span>
<span style="color: #808080">QDEBUG : KFilePlacesModelTest::initTestCase() void Solid::Backends::Fake::FakeManager::parseMachineFile() Parsing fake computer XML: "/home/elvis/dev/kde/kio/autotests/fakecomputer.xml" </span>
<span style="color: #808080"></span>
<span style="color: #808080">PASS : KFilePlacesModelTest::initTestCase()</span>
<span style="color: #808080">FAIL! : KFilePlacesModelTest::testInitialState() Compared values are not the same</span>
<span style="color: #808080"> Actual (m_places->rowCount()): 6</span>
<span style="color: #808080"> Expected (4) : 4</span>
<span style="color: #808080"> Loc: [../autotests/kfileplacesmodeltest.cpp(200)]</span>
<span style="color: #808080">QDEBUG : KFilePlacesModelTest::testInitialList() Expected: ("/home/elvis", "/", "trash:/", "remote:/", "/media/nfs", "/foreign", "/media/floppy0", "/media/XO-Y4", "/media/cdrom")</span>
<span style="color: #808080">QDEBUG : KFilePlacesModelTest::testInitialList() Got: ("/home/elvis", "/home/elvis/Desktop", "/home/elvis/Downloads", "/", "trash:/", "remote:/")</span>
<span style="color: #808080">FAIL! : KFilePlacesModelTest::testInitialList() Compared lists have different sizes.</span>
<span style="color: #808080"> Actual (placesUrls()) size: 6</span>
<span style="color: #808080"> Expected (urls) size: 9</span>
<span style="color: #808080"> Loc: [../autotests/kfileplacesmodeltest.cpp(236)]</span>
<span style="color: #808080"></span></pre></div></div>
</blockquote>
<p>That's a different test (from the same file). That part of the test assumes that you have a clean home directory. I run this tests with a wrapper, something like:</p>
<p>HOMETMP=$(mktemp -d)<br />
trap 'rm -rf $HOMETMP' EXIT<br />
export HOME="$HOMETMP"</p>
<p>xvfb-run -a dbus-run-session -- obj-x86_64-linux-gnu/bin/kfileplacesmodeltest</p>
<p>The complete version can be seen here:<br />
<a href="https://salsa.debian.org/qt-kde-team/kde/kio/tree/master/debian/tests" class="remarkup-link" target="_blank" rel="noreferrer">https://salsa.debian.org/qt-kde-team/kde/kio/tree/master/debian/tests</a></p>
<p>That's after applying the patches:<br />
<a href="https://salsa.debian.org/qt-kde-team/kde/kio/tree/master/debian/patches" class="remarkup-link" target="_blank" rel="noreferrer">https://salsa.debian.org/qt-kde-team/kde/kio/tree/master/debian/patches</a></p>
<p>The Debian test results can be seen here:<br />
<a href="https://ci.debian.net/data/autopkgtest/unstable/amd64/k/kio/342727/log.gz" class="remarkup-link" target="_blank" rel="noreferrer">https://ci.debian.net/data/autopkgtest/unstable/amd64/k/kio/342727/log.gz</a></p>
<p>There is an error in a different part of this test, it seems that kio strips the -full part of the trash icon name but not always. (see src/filewidgets/kfileplacesitem.cpp : 418)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13018">https://phabricator.kde.org/D13018</a></div></div><br /><div><strong>To: </strong>renatoo<br /><strong>Cc: </strong>maximilianocuria, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>