<table><tr><td style="">bruns requested changes to this revision.<br />bruns added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12320">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12320#inline-65738">View Inline</a><span style="color: #4b4d51; font-weight: bold;">embeddedimagedata.cpp:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">types</span> <span style="color: #aa2211">==</span> <span class="n">EmbeddedImageData</span><span style="color: #aa2211">::</span><span class="n">FrontCover</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">imageData</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">EmbeddedImageData</span><span style="color: #aa2211">::</span><span class="n">FrontCover</span><span class="p">,</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">getFrontCover</span><span class="p">(</span><span class="n">fileUrl</span><span class="p">,</span><span class="n">mimeType</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">should be <tt style="background: #ebebeb; font-size: 13px;">types & EmbeddedImageData::FrontCover</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12320#inline-65734">View Inline</a><span style="color: #4b4d51; font-weight: bold;">embeddedimagedata.cpp:149</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">pictureFlac</span><span style="color: #aa2211">-></span><span class="n">type</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">pictureFlac</span><span style="color: #aa2211">-></span><span class="n">FrontCover</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="n">QByteArray</span><span class="p">(</span><span class="n">pictureFlac</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">().</span><span class="n">data</span><span class="p">(),</span><span class="n">pictureFlac</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">().</span><span class="n">size</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">missing space after <tt style="background: #ebebeb; font-size: 13px;">,</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12320#inline-65735">View Inline</a><span style="color: #4b4d51; font-weight: bold;">embeddedimagedata.cpp:170</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Attached Picture.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">lstPic</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span><span class="n">TagLib</span><span style="color: #aa2211">::</span><span class="n">List</span><span style="color: #aa2211"><</span><span class="n">TagLib</span><span style="color: #aa2211">::</span><span class="n">FLAC</span><span style="color: #aa2211">::</span><span class="n">Picture</span> <span style="color: #aa2211">*>::</span><span class="n">Iterator</span> <span class="n">it</span> <span style="color: #aa2211">=</span> <span class="n">lstPic</span><span class="p">.</span><span class="n">begin</span><span class="p">();</span> <span class="n">it</span> <span style="color: #aa2211">!=</span> <span class="n">lstPic</span><span class="p">.</span><span class="n">end</span><span class="p">();</span> <span style="color: #aa2211">++</span><span class="n">it</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is identical to the "audio/flac" case, can you use the same variable names etc. in both places?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12320#inline-65717">View Inline</a><span style="color: #4b4d51; font-weight: bold;">astippich</span> wrote in <span style="color: #4b4d51; font-weight: bold;">embeddedimagedata.h:40</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">std::make_unique is C++14, right? According to <a href="https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements</a><br />
C++11 is the currently minimum version, so I left it unchanged. This is also similar to the other classes in KFileMetaData</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">std::make_unique</tt> is just a convenience helper</p>
<p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">auto foo = std::make_unique<Foo></tt> is exactly the same as <tt style="background: #ebebeb; font-size: 13px;">auto foo = std::unique_ptr<Foo>(new Foo());</tt><br />
see <a href="http://en.cppreference.com/w/cpp/memory/unique_ptr/make_unique" class="remarkup-link" target="_blank" rel="noreferrer">http://en.cppreference.com/w/cpp/memory/unique_ptr/make_unique</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12320">https://phabricator.kde.org/D12320</a></div></div><br /><div><strong>To: </strong>astippich, mgallien, michaelh, bruns<br /><strong>Cc: </strong>kde-frameworks-devel, Baloo, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham<br /></div>