<table><tr><td style="">rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12734">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12734#259445" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12734#259445</a>, <a href="https://phabricator.kde.org/p/muhlenpfordt/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@muhlenpfordt</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I wanted to be careful here since I'm a bit afraid of changing library functions. If you think it's ok for <tt style="background: #ebebeb; font-size: 13px;">Applications/18.04</tt> I'll rebase it.</p></div>
</blockquote>
<p>How else would you fix problems in a library ;)</p>
<p>Nevertheless, let's check the impact of this again: <a href="https://lxr.kde.org/ident?_i=thumbForDirectory" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/ident?_i=thumbForDirectory</a></p>
<p>Does not look too critical to me, and we probably tested most of the code paths.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R320 KIO Extras</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12734">https://phabricator.kde.org/D12734</a></div></div><br /><div><strong>To: </strong>muhlenpfordt, Frameworks, rkflx<br /><strong>Cc: </strong>ngraham, rkflx<br /></div>