<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12388">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12388#inline-64963">View Inline</a><span style="color: #4b4d51; font-weight: bold;">outputdevice.cpp:321</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">auto</span> <span class="n">setCurve</span> <span style="color: #aa2211">=</span> <span class="p">[](</span><span style="color: #aa4000">struct</span> <span class="n">wl_array</span> <span style="color: #aa2211">*</span><span class="n">curve</span><span class="p">,</span> <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">quint16</span><span style="color: #aa2211">></span> <span style="color: #aa2211">*</span><span class="n">destination</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">destination</span><span style="color: #aa2211">-></span><span class="n">resize</span><span class="p">(</span><span class="n">curve</span><span style="color: #aa2211">-></span><span class="n">size</span> <span style="color: #aa2211">/</span> <span style="color: #aa4000">sizeof</span><span class="p">(</span><span style="color: #aa4000">uint16_t</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That's not C so you can get rid of <tt style="background: #ebebeb; font-size: 13px;">struct</tt> keyword. ;-)<br />
Also, you could constify <tt style="background: #ebebeb; font-size: 13px;">curve</tt> to show that it's read-only.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12388#inline-64964">View Inline</a><span style="color: #4b4d51; font-weight: bold;">outputconfiguration_interface.cpp:208</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">auto</span> <span class="n">checkArg</span> <span style="color: #aa2211">=</span> <span class="p">[](</span><span class="n">wl_array</span> <span style="color: #aa2211">*</span><span class="n">newColor</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">quint16</span><span style="color: #aa2211">></span> <span style="color: #aa2211">&</span><span class="n">oldColor</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span class="p">(</span><span class="n">newColor</span><span style="color: #aa2211">-></span><span class="n">size</span> <span style="color: #aa2211">%</span> <span style="color: #aa4000">sizeof</span><span class="p">(</span><span style="color: #aa4000">uint16_t</span><span class="p">)</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">)</span> <span style="color: #aa2211">&&</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">constify newColor?<br />
Also, you could cast oldColor.size() in C++ manner, e.g. static_cast<size_t>(...)?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12388#inline-64965">View Inline</a><span style="color: #4b4d51; font-weight: bold;">outputconfiguration_interface.cpp:221</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">auto</span> <span class="n">fillVector</span> <span style="color: #aa2211">=</span> <span class="p">[](</span><span class="n">wl_array</span> <span style="color: #aa2211">*</span><span class="n">array</span><span class="p">,</span> <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">quint16</span><span style="color: #aa2211">></span> <span style="color: #aa2211">*</span><span class="n">v</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">uint16_t</span> <span style="color: #aa2211">*</span><span class="n">pos</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span style="color: #aa4000">uint16_t</span><span style="color: #aa2211">*</span><span class="p">)</span><span class="n">array</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">constify wl_array?<br />
constify pos, e.g. <tt style="background: #ebebeb; font-size: 13px;">uint16_t const *pos</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12388#inline-64967">View Inline</a><span style="color: #4b4d51; font-weight: bold;">outputdevice_interface.cpp:420</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">auto</span> <span class="n">fillArray</span> <span style="color: #aa2211">=</span> <span class="p">[](</span><span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">quint16</span><span style="color: #aa2211">></span> <span style="color: #aa2211">&</span><span class="n">origin</span><span class="p">,</span> <span class="n">wl_array</span> <span style="color: #aa2211">*</span><span class="n">dest</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">auto</span> <span style="color: #a0a000">c</span> <span class="p">:</span> <span class="n">origin</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">constify origin?</p>

<p style="padding: 0; margin: 8px;">Can't you memcpy here?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12388">https://phabricator.kde.org/D12388</a></div></div><br /><div><strong>To: </strong>romangg, Frameworks, davidedmundson, graesslin<br /><strong>Cc: </strong>graesslin, davidedmundson, zzag, cfeck, michaelh, bruns<br /></div>