<table><tr><td style="">rkflx added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12337">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12337#inline-64682">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdiroperator.cpp:1888</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">actionCollection</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"sorting menu"</span><span class="p">),</span> <span class="n">sortMenu</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">sortMenu</span><span style="color: #aa2211">-></span><span class="n">setIcon</span><span class="p">(</span><span class="n">QIcon</span><span style="color: #aa2211">::</span><span class="n">fromTheme</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"itemize"</span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">While we agreed upon wanting a better icon, until that's done I'd prefer <tt style="background: #ebebeb; font-size: 13px;">view-sort-ascending</tt> instead. For me, <tt style="background: #ebebeb; font-size: 13px;">itemize</tt> has no connection to sorting at all, sorry.</p>
<p style="padding: 0; margin: 8px;">I'm aware my alternative shows a specific mode, but TBH I don't think users will be put off too much by this detail, in particular because it is the only sorting-related icon in the dialog.</p>
<p style="padding: 0; margin: 8px;">Anyway, that's just my preference. Let me know if you think <tt style="background: #ebebeb; font-size: 13px;">itemize</tt> is vastly better.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12337#inline-64686">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfilewidget.cpp:365</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">opsWidgetLayout</span><span style="color: #aa2211">-></span><span class="n">setSpacing</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #74777d"><span class="bright">//</span>d->toolbar = new KToolBar(this, true);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">toolbar</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KToolBar</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">opsWidget</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">toolbar</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KToolBar</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">toolbar</span><span style="color: #aa2211">-></span><span class="n">setObjectName</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"KFileWidget::toolbar"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12337#inline-64684">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfilewidget.cpp:365-369</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #74777d"><span class="bright">//</span>d->toolbar = new KToolBar(this, true);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">toolbar</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KToolBar</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">opsWidget</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">toolbar</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KToolBar</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">toolbar</span><span style="color: #aa2211">-></span><span class="n">setObjectName</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"KFileWidget::toolbar"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">toolbar</span><span style="color: #aa2211">-></span><span class="n">setMovable</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">opsWidgetLayout</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">toolbar</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12337#inline-64687">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfilewidget.cpp:554-559</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Tweak the look and feel of the sort menu button</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">foreach</span><span class="p">(</span><span class="n">QToolButton</span><span style="color: #aa2211">*</span> <span class="n">button</span><span class="p">,</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">toolbar</span><span style="color: #aa2211">-></span><span class="n">findChildren</span><span style="color: #aa2211"><</span><span class="n">QToolButton</span><span style="color: #aa2211">*></span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">button</span><span style="color: #aa2211">-></span><span class="n">defaultAction</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">coll</span><span style="color: #aa2211">-></span><span class="n">action</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"sorting menu"</span><span class="p">)))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">button</span><span style="color: #aa2211">-></span><span class="n">setPopupMode</span><span class="p">(</span><span class="n">QToolButton</span><span style="color: #aa2211">::</span><span class="n">InstantPopup</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This also worked for me, and would avoid the <tt style="background: #ebebeb; font-size: 13px;">foreach</tt>:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">KActionMenu *x = new KActionMenu(QIcon::fromTheme(QStringLiteral("configure")), i18n("Options"), this);
x->setMenu(coll->action(QStringLiteral("sorting menu"))->menu());
x->setDelayed(false);
d->toolbar->addAction(x);</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12337#inline-64683">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfilewidget.cpp:561</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KUrlCompletion</span> <span style="color: #aa2211">*</span><span class="n">pathCompletionObj</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KUrlCompletion</span><span class="p">(</span><span class="n">KUrlCompletion</span><span style="color: #aa2211">::</span><span class="n">DirCompletion</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unintentional newline?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12337#inline-64685">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfilewidget.cpp:1410</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">boxLayout</span><span style="color: #aa2211">-></span><span class="n">setMargin</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">);</span> <span style="color: #74777d">// no additional margin to the already existing</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">boxLayout</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span><span class="n">toolbar</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12337">https://phabricator.kde.org/D12337</a></div></div><br /><div><strong>To: </strong>ngraham, Frameworks, Dolphin, VDG, rkflx<br /><strong>Cc: </strong>andreaska, markg, broulik, anemeth, michaelh, bruns<br /></div>