<table><tr><td style="">brauch added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12662">View Revision</a></tr></table><br /><div><div><p>Looks good from the implementation too so far. One thing I do not see is any changes to the cursorToX / xToCursor functions, is there really no change required there?</p>
<p>Some things which come to my mind for testing would be:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">is selection rendered correctly if it includes notes, at the end, beginning, or middle of lines, also mult-line selections?</li>
<li class="remarkup-list-item">what happens when clicking or dragging from or into the notes?</li>
<li class="remarkup-list-item">does it still work properly with dynamic word-wrap on?</li>
<li class="remarkup-list-item">does it work properly with code-folding? what happens if a note is at the border of a folding region?</li>
</ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12662#inline-64812">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katedocument.cpp:5295</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">provider</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">reset</span><span class="p">()),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">inlineNotesReset</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">provider</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">lineChanged</span><span class="p">(</span><span style="color: #aa4000">int</span><span class="p">)),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">inlineNotesLineChanged</span><span class="p">(</span><span style="color: #aa4000">int</span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you use new-style connect here, i.e. the function-pointer syntax<br />
connect(provider, &NoteProvider::reset, this, &DocumentPrivate::inlineNotesReset)?<br />
This gives compile-time argument type checking.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12662#inline-64814">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katerenderer.cpp:771</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Determine the position where to paint the note.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// We start by getting the x coordinate of cursor placed to the column.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qreal</span> <span class="n">x</span> <span style="color: #aa2211">=</span> <span class="n">range</span><span style="color: #aa2211">-></span><span class="n">viewLine</span><span class="p">(</span><span class="n">viewLine</span><span class="p">).</span><span class="n">lineLayout</span><span class="p">().</span><span class="n">cursorToX</span><span class="p">(</span><span class="n">column</span><span class="p">)</span> <span style="color: #aa2211">-</span> <span class="n">xStart</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">indent</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12662#inline-64816">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katerenderer.cpp:777</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// note should be painted and the cursor gets placed at the right side of it. So we have to</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// subtract the width of the note to get to left side of the hole.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">x</span> <span style="color: #aa2211">-=</span> <span class="n">inlineNote</span><span style="color: #aa2211">-></span><span class="n">width</span><span class="p">(</span><span class="n">lineHeight</span><span class="p">(),</span> <span class="n">currentFontMetrics</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">indent</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12662">https://phabricator.kde.org/D12662</a></div></div><br /><div><strong>To: </strong>michalsrb, KTextEditor<br /><strong>Cc: </strong>brauch, Frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>