<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson added a reviewer: Plasma.<br />Restricted Application added a project: Frameworks.<br />Restricted Application added a subscriber: Frameworks.<br />davidedmundson requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12648">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The order of udisks evaluation has changed from:</p>
<p>call Mount<br />
propertiesChanged<br />
mount call returns</p>
<p>call Mount<br />
mount call returns<br />
propertiesChanged</p>
<p>The mount has finished, but the property is not yet updated.</p>
<p>Solid caches properties, updating them when they change. This worked<br />
before, but due to the re-ordering client code gets "setupDone" requests<br />
the mount point, gets an outdated version from the cache and we get<br />
errors. Invalidating the cache causes us to round-trip to the udisks<br />
daemon meaning we'll have the correct values.</p>
<p>BUG: 370975</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Diagnosed but with dbus-monitor trace <br />
Asked someone on the bug report to test this</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R245 Solid</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12648">https://phabricator.kde.org/D12648</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/solid/devices/backends/udisks2/udisksdevice.cpp<br />
src/solid/devices/backends/udisks2/udisksdevice.h<br />
src/solid/devices/backends/udisks2/udisksstorageaccess.cpp</div></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>Frameworks, michaelh, bruns<br /></div>