<table><tr><td style="">jtamate updated this revision to Diff 33242.<br />jtamate edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-baim24cea6o2xx3/">(Show Details)</a><br />jtamate added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12371">View Revision</a></tr></table><br /><div><div><p>If I use if (!u.path().isEmpty()) or if (!u.path().isEmpty() && !u.path().endsWith('/')), <br />
as soon as I enter the url fish://127.0.0.1 (without trailing /), I'm redirected to fish://127.0.0.1/home/jtorres (that didn't happen before), and after finishing reading the directory, assertion.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">kf5.kio.core: Internal error: job is listing QUrl("fish://127.0.0.1/home/jtorres") but directoryData says no listers are currently listing "fish://127.0.0.1/home/jtorres"
kf5.kio.core.dirlister: Items in use:
kf5.kio.core.dirlister: "fish://127.0.0.1/home/jtorres" URL: QUrl("fish://127.0.0.1/home/jtorres") rootItem: QUrl("fish://127.0.0.1/home/jtorres") autoUpdates refcount: 1 complete: true "with 1010 items."
kf5.kio.core.dirlister: Directory data:
kf5.kio.core.dirlister: "fish://127.0.0.1/home/jtorres" 0 listers: ""
kf5.kio.core.dirlister: "fish://127.0.0.1/home/jtorres" 1 holders: " 0x3279dd0"
kf5.kio.core.dirlister: Jobs:
kf5.kio.core.dirlister: Items in cache:
kf5.kio.core.dirlister: "file:///virtual/kde5/5kde/build/frameworks/kio" rootItem: "file:///virtual/kde5/5kde/build/frameworks/kio" with 16 items.
ASSERT: "!dirData.listersCurrentlyListing.isEmpty()" in file /g/5kde/frameworks/kio/src/core/kcoredirlister.cpp, line 1208
#9 QMessageLogger::fatal (this=this@entry=0x7fff05486530, msg=msg@entry=0x7f36ba7ddeb0 "ASSERT: \"%s\" in file %s, line %d") at global/qlogging.cpp:816
#10 0x00007f36ba548e86 in qt_assert (assertion=assertion@entry=0x7f36beb7b410 "!dirData.listersCurrentlyListing.isEmpty()", file=file@entry=0x7f36beb7b0b0 "/g/5kde/frameworks/kio/src/core/kcoredirlister.cpp", line=line@entry=1208) at global/qglobal.cpp:3123
#11 0x00007f36beb40230 in KCoreDirListerCache::slotEntries (this=0x7f36bedaf420 <(anonymous namespace)::Q_QGS_kDirListerCache::innerFunction()::holder>, job=<optimized out>, entries=...) at /g/5kde/frameworks/kio/src/core/kcoredirlister.cpp:1208
...
#18 0x00007f36beae500d in KIO::ListJob::entries (this=this@entry=0x324dd20, _t1=<optimized out>, _t1@entry=0x324dd20, _t2=...) at /virtual/kde5/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_listjob.cpp:232
#19 0x00007f36beae6ce2 in KIO::ListJobPrivate::slotListEntries (this=0x37bd250, list=...) at /g/5kde/frameworks/kio/src/core/listjob.cpp:154
#20 0x00007f36beae7052 in KIO::ListJobPrivate::<lambda(const UDSEntryList&)>::operator() (list=..., __closure=<optimized out>) at /g/5kde/frameworks/kio/src/core/listjob.cpp:288</pre></div>
<p>Checking for the slash in the string representation of the url, not only in the path part, works for me.</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">Do not chang</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Append / to th</span>e url path o<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">f non local</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">nly if the string representation of the</span> url<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">s</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> doesn't end in /</span>.<div style="padding: 8px 0;">...</div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D12371?vs=33211&id=33242">https://phabricator.kde.org/D12371?vs=33211&id=33242</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12371">https://phabricator.kde.org/D12371</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/filewidgets/kfilewidget.cpp</div></div></div><br /><div><strong>To: </strong>jtamate, dfaure, Frameworks, apol<br /><strong>Cc: </strong>anthonyfieroni, apol, michaelh, bruns<br /></div>