<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12371">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12371#inline-64154">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfilewidget.cpp:1523</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// append '/' if needed: url combo does not add it</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// tokenize() expects it because uses KUrl::setFileName()</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QUrl</span> <span class="n">u</span><span class="p">(</span><span class="n">url</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This needs to be updated btw, to "because it uses QUrl::adjusted(QUrl::RemoveFilename)", but I think the idea remains the same.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12371#inline-64155">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfilewidget.cpp:1525</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QUrl</span> <span class="n">u</span><span class="p">(</span><span class="n">url</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">u</span><span class="p">.</span><span class="n">path</span><span class="p">().</span><span class="n">endsWith</span><span class="p">(</span><span style="color: #766510">'/'</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">u</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">isLocalFile</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #aa2211">!</span><span class="n">u</span><span class="p">.</span><span class="n">path</span><span class="p">().</span><span class="n">endsWith</span><span class="p">(</span><span style="color: #766510">'/'</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">u</span><span class="p">.</span><span class="n">setPath</span><span class="p">(</span><span class="n">u</span><span class="p">.</span><span class="n">path</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">'/'</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't think this is correct, we still need that code to be called for ftp:// and similar.</p>

<p style="padding: 0; margin: 8px;">I think this needs to be if (!u.path().isEmpty()) so that only smb:// and ftp://host (which is supposed to redirect to the home dir) are untouched, and everything else gets a trailing slash.</p>

<p style="padding: 0; margin: 8px;">Thanks for the investigation.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12371">https://phabricator.kde.org/D12371</a></div></div><br /><div><strong>To: </strong>jtamate, dfaure, Frameworks, apol<br /><strong>Cc: </strong>anthonyfieroni, apol, michaelh, bruns<br /></div>